Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Curl auto instrumentation distributed tracing headers propagation, request and response headers capturing (#1420) #314

Merged
merged 5 commits into from
Nov 6, 2024
Merged

Curl auto instrumentation distributed tracing headers propagation, request and response headers capturing (#1420) #314

merged 5 commits into from
Nov 6, 2024

Conversation

intuibase
Copy link
Contributor

No description provided.

@intuibase intuibase requested a review from a team as a code owner October 31, 2024 17:19
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.60104% with 22 lines in your changes missing coverage. Please review.

Project coverage is 79.57%. Comparing base (27a188b) to head (884a13f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rc/Instrumentation/Curl/src/CurlHandleMetadata.php 78.31% 18 Missing ⚠️
...c/Instrumentation/Curl/src/CurlInstrumentation.php 96.19% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #314      +/-   ##
============================================
+ Coverage     79.12%   79.57%   +0.44%     
- Complexity      676      720      +44     
============================================
  Files            67       68       +1     
  Lines          2822     2913      +91     
============================================
+ Hits           2233     2318      +85     
- Misses          589      595       +6
Flag Coverage Δ
Aws 85.55% <ø> (ø)
Instrumentation/CakePHP 20.00% <ø> (ø)
Instrumentation/CodeIgniter 73.77% <ø> (ø)
Instrumentation/Curl 90.29% <88.60%> (-0.73%) ⬇️
Instrumentation/Guzzle 69.51% <ø> (ø)
Instrumentation/HttpAsyncClient 81.25% <ø> (ø)
Instrumentation/IO 70.68% <ø> (ø)
Instrumentation/MongoDB 76.31% <ø> (ø)
Instrumentation/OpenAIPHP 87.31% <ø> (ø)
Instrumentation/PDO 89.95% <ø> (ø)
Instrumentation/Psr14 ?
Instrumentation/Psr15 93.82% <ø> (ø)
Instrumentation/Psr16 97.56% <ø> (ø)
Instrumentation/Psr18 81.15% <ø> (ø)
Instrumentation/Psr6 97.67% <ø> (ø)
Instrumentation/Slim 86.89% <ø> (ø)
Instrumentation/Symfony 88.70% <ø> (ø)
Instrumentation/Yii 77.68% <ø> (ø)
Propagation/ServerTiming 100.00% <ø> (ø)
Propagation/TraceResponse 100.00% <ø> (ø)
ResourceDetectors/Container 93.02% <ø> (ø)
Sampler/RuleBased 33.51% <ø> (ø)
Shims/OpenTracing 92.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Instrumentation/Curl/src/HeadersPropagator.php 100.00% <100.00%> (ø)
...c/Instrumentation/Curl/src/CurlInstrumentation.php 93.63% <96.19%> (+2.61%) ⬆️
...rc/Instrumentation/Curl/src/CurlHandleMetadata.php 78.31% <78.31%> (ø)

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27a188b...884a13f. Read the comment docs.

@intuibase intuibase force-pushed the curl_headers_propagation branch from 6b2a1af to 19276e7 Compare October 31, 2024 20:03
@intuibase
Curl auto instrumentation distributed tracing headers propagation, re…
382525e 
…quest and response headers capturing (#1420)
@intuibase intuibase force-pushed the curl_headers_propagation branch from 19276e7 to 382525e Compare October 31, 2024 21:31
ChrisLightfootWild
ChrisLightfootWild reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@ChrisLightfootWild ChrisLightfootWild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some linting-esque feedback (sorry! 👼 ) and a couple of minor tweaks.

src/Instrumentation/Curl/README.md Outdated Show resolved Hide resolved
src/Instrumentation/Curl/src/CurlHandleMetadata.php Outdated Show resolved Hide resolved
src/Instrumentation/Curl/src/CurlInstrumentation.php Outdated Show resolved Hide resolved
src/Instrumentation/Curl/src/CurlInstrumentation.php Outdated Show resolved Hide resolved
src/Instrumentation/Curl/src/CurlInstrumentation.php Outdated Show resolved Hide resolved
src/Instrumentation/Curl/src/CurlHandleMetadata.php Outdated Show resolved Hide resolved
src/Instrumentation/Curl/src/CurlHandleMetadata.php Outdated Show resolved Hide resolved
src/Instrumentation/Curl/src/CurlHandleMetadata.php Outdated Show resolved Hide resolved
src/Instrumentation/Curl/tests/Integration/CurlMultiInstrumentationTest.php Outdated Show resolved Hide resolved
@ChrisLightfootWild ChrisLightfootWild requested a review from a team October 31, 2024 23:01
@ChrisLightfootWild ChrisLightfootWild requested a review from a team November 4, 2024 20:42
@bobstrecansky bobstrecansky merged commit 799985e into open-telemetry:main Nov 6, 2024
98 of 122 checks passed
@intuibase intuibase mentioned this pull request Nov 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisLightfootWild ChrisLightfootWild ChrisLightfootWild approved these changes

@brettmc brettmc brettmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@intuibase @brettmc @ChrisLightfootWild @bobstrecansky