continue on read failure

open-telemetry · Dec 14, 2024 · bc5fbb9 · bc5fbb9
1 parent c88a1dc
commit bc5fbb9
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/SDK/Resource/Detectors/Host.php b/src/SDK/Resource/Detectors/Host.php
@@ -59,7 +59,11 @@ private function getLinuxId(): ?string
                 if (is_file($file) && is_readable($file)) {
                     $contents = file_get_contents($file);
 
-                    return $contents !== false ? trim($contents) : null;
+                    if ($contents === false) {
+                        continue;
+                    }
+
+                    return trim($contents);
                 }
             } catch (Throwable $t) {
                 //do nothing
@@ -77,7 +81,9 @@ private function getBsdId(): ?string
             if (is_file($file) && is_readable($file)) {
                 $contents = file_get_contents($file);
 
-                return $contents !== false ? trim($contents) : null;
+                if ($contents !== false) {
+                    return trim($contents);
+                }
             }
         } catch (Throwable $t) {
             //do nothing