remove global configuration resolver #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposing it through Globals can cause a race condition. If something (eg, a contrib module) retrieves the configuration resolver from Globals too early during autoloading, then it causes the rest of the objects from Globals to be initialized. This can happen before all required modules have been registered (depending on autoload->files execution order, which is variable). Instead, create a simple API config resolver which does the basics of what the SDK one does (without all the type checking and validation).
Codecov Report
@@ Coverage Diff @@
## main #1118 +/- ##
============================================
+ Coverage 83.05% 83.50% +0.45%
- Complexity 2151 2160 +9
============================================
Files 278 279 +1
Lines 6119 6136 +17
============================================
+ Hits 5082 5124 +42
+ Misses 1037 1012 -25
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
bobstrecansky
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing it through Globals can cause a race condition. If something (eg, a contrib module) retrieves the configuration resolver from Globals too early during autoloading, then it causes the rest of the objects from Globals to be initialized. This can happen before all required modules have been registered (depending on autoload->files execution order, which is variable). Instead, create a simple API config resolver which does the basics of what the SDK one does (without all the type checking and validation).