Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix broken link describing the usage of env vars for config #1121

Closed

Conversation

roman-kovalev
Copy link
Contributor

I've noticed that one of the links in the repo is outdated. Here's a fix

@roman-kovalev roman-kovalev requested a review from a team October 5, 2023 03:17
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #1121 (271a84a) into main (75bb45f) will not change coverage.
The diff coverage is n/a.

❗ Current head 271a84a differs from pull request most recent head 48c253e. Consider uploading reports for the commit 48c253e to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1121   +/-   ##
=========================================
  Coverage     83.50%   83.50%           
  Complexity     2160     2160           
=========================================
  Files           279      279           
  Lines          6136     6136           
=========================================
  Hits           5124     5124           
  Misses         1012     1012           
Flag Coverage Δ
7.4 82.12% <ø> (ø)
8.0 83.43% <ø> (ø)
8.1 83.57% <ø> (ø)
8.2 83.57% <ø> (ø)
8.3 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/SDK/Resource/Detectors/Environment.php 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75bb45f...48c253e. Read the comment docs.

@brettmc
Copy link
Collaborator

brettmc commented Oct 5, 2023

Thanks @roman-kovalev - you just need to sign the CLA so that I can merge this.

@roman-kovalev
Copy link
Contributor Author

Thanks @roman-kovalev - you just need to sign the CLA so that I can merge this.

@brettmc I did it few hours ago but still seeing this failed check 😕 Maybe you could kindly suggest what to do next with the signed PDF?

@roman-kovalev
Copy link
Contributor Author

Opened another one, hopefully it will fix the CLA issue

@brettmc
Copy link
Collaborator

brettmc commented Oct 5, 2023

@brettmc I did it few hours ago but still seeing this failed check 😕 Maybe you could kindly suggest what to do next with the signed PDF?

signed PDF? Is this a company CLA? I thought it was all online (at least, that was my experience signing an individual CLA). If you've signed a physical document, it might be waiting for a human to process it, but I don't know anything about that. Resubmitting the same PR multiple times won't help though. I can force it to re-check the CLA from a PR, so please don't submit any new PRs for this.

@brettmc brettmc reopened this Oct 5, 2023
@linux-foundation-easycla
Copy link

CLA Not Signed

@brettmc
Copy link
Collaborator

brettmc commented Oct 5, 2023

/easycla

@roman-kovalev
Copy link
Contributor Author

roman-kovalev commented Oct 5, 2023

signed PDF? Is this a company CLA?

No, not a physical doc, an individual via docusign. It is passed in another PR btw.
I think the problem with this one is that I accidentally pushed a commit using my work GH profile @roman-kovalev-aks that's why it messed up.
I'd suggest you to close this one and approve #1122 instead, all good there 🙂
Thank you!

@brettmc brettmc closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants