Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improving more tests #1127

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

weslenteche
Copy link
Contributor

As my first code contribution, I wanted to add more test scenarios.

@weslenteche weslenteche requested a review from a team October 14, 2023 13:38
@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Merging #1127 (4b643f3) into main (ea86fe1) will increase coverage by 0.78%.
The diff coverage is n/a.

❗ Current head 4b643f3 differs from pull request most recent head 154c8e7. Consider uploading reports for the commit 154c8e7 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1127      +/-   ##
============================================
+ Coverage     83.50%   84.28%   +0.78%     
  Complexity     2160     2160              
============================================
  Files           279      279              
  Lines          6136     6136              
============================================
+ Hits           5124     5172      +48     
+ Misses         1012      964      -48     
Flag Coverage Δ
7.4 82.91% <ø> (+0.78%) ⬆️
8.0 84.21% <ø> (+0.78%) ⬆️
8.1 84.35% <ø> (+0.78%) ⬆️
8.2 84.35% <ø> (+0.78%) ⬆️
8.3 84.35% <ø> (+0.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea86fe1...154c8e7. Read the comment docs.

@brettmc brettmc merged commit f22ffa0 into open-telemetry:main Oct 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants