Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate semconv 1.24.0 #1219

Merged
merged 3 commits into from
Jan 23, 2024
Merged

generate semconv 1.24.0 #1219

merged 3 commits into from
Jan 23, 2024

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Jan 22, 2024

generate latest semconv version, and add back Trace and Resource attribute values which seem to have been dropped in a previous change.

generate latest semconv version, and add back Trace and Resource attribute values which
seem to have been dropped in a previous change.
@brettmc brettmc requested a review from a team January 22, 2024 00:48
two trace attributes were deleted then added back to upstream semconv, so remove our ones.
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (102f5dc) 83.20% compared to head (debe4b6) 83.20%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1219   +/-   ##
=========================================
  Coverage     83.20%   83.20%           
  Complexity     2262     2262           
=========================================
  Files           285      285           
  Lines          6435     6435           
=========================================
  Hits           5354     5354           
  Misses         1081     1081           
Flag Coverage Δ
7.4 81.83% <100.00%> (ø)
8.0 83.09% <100.00%> (ø)
8.1 83.26% <100.00%> (ø)
8.2 83.26% <100.00%> (ø)
8.3 83.26% <100.00%> (ø)
8.4 83.26% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Contrib/Otlp/SpanConverter.php 99.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1af8334...debe4b6. Read the comment docs.

@brettmc brettmc merged commit 810aa2f into open-telemetry:main Jan 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants