Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required $contentType arguments #1225

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Add required $contentType arguments #1225

merged 1 commit into from
Jan 27, 2024

Conversation

overtrue
Copy link
Contributor

No description provided.

@overtrue overtrue requested a review from a team January 26, 2024 07:18
Copy link

welcome bot commented Jan 26, 2024

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

Copy link

linux-foundation-easycla bot commented Jan 26, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: overtrue / name: 安正超 (7b107c2)

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f2ab3c5) 83.20% compared to head (7b107c2) 83.20%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1225   +/-   ##
=========================================
  Coverage     83.20%   83.20%           
  Complexity     2263     2263           
=========================================
  Files           285      285           
  Lines          6436     6436           
=========================================
  Hits           5355     5355           
  Misses         1081     1081           
Flag Coverage Δ
7.4 81.84% <ø> (ø)
8.0 83.10% <ø> (ø)
8.1 83.26% <ø> (ø)
8.2 83.26% <ø> (ø)
8.3 83.26% <ø> (ø)
8.4 83.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2ab3c5...7b107c2. Read the comment docs.

@brettmc brettmc merged commit 84cf0a5 into open-telemetry:main Jan 27, 2024
13 checks passed
@brettmc
Copy link
Collaborator

brettmc commented Jan 27, 2024

Thanks, @overtrue !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants