Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding OTEL_PHP_EXCLUDED_URLS #1226

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Feb 1, 2024

Modeled on python's feature to turn off all instrumentation for specific URLs, https://opentelemetry.io/docs/languages/python/automatic/agent-config/#excluded-urls this feature will effectively disable SDK autoloading if there is a request URI that matches one of the provided excluded URLs, and no-op implementations will be used for tracer/logger/meter providers.

Modeled on python's feature to turn off all instrumentation for specific URLs,
https://opentelemetry.io/docs/languages/python/automatic/agent-config/#excluded-urls
this feature will effectively disable SDK autoloading if there is a request URI that
matches one of the provided excluded URLs, and no-op implementations will be used
for tracer/logger/meter providers.
@brettmc brettmc requested a review from a team February 1, 2024 06:01
@brettmc
Copy link
Collaborator Author

brettmc commented Feb 1, 2024

The primary use-case for this would be for shared-nothing PHP setups (apache, nginx) to not generate 1000s of traces for URLs such as /healthcheck...

@bobstrecansky bobstrecansky merged commit 36e2b7f into open-telemetry:main Feb 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants