-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add host.id for non-containerized systems #1266
Add host.id for non-containerized systems #1266
Conversation
Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1266 +/- ##
============================================
- Coverage 83.87% 83.78% -0.10%
- Complexity 2136 2148 +12
============================================
Files 296 296
Lines 6104 6137 +33
============================================
+ Hits 5120 5142 +22
- Misses 984 995 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a couple of untested suggestions for discussion/consideration!
Co-authored-by: Chris Lightfoot-Wild <[email protected]>
Co-authored-by: Chris Lightfoot-Wild <[email protected]>
Co-authored-by: Chris Lightfoot-Wild <[email protected]>
Done! Thanks, @matt-hensley |
Fixes #1263
Only mocked the file system for Linux.
BSD, MacOS, and Windows all shell out to get the ID. I've added tests covering parsing the output on MacOS and Windows.
Any and all feedback is welcome, I haven't written PHP in a long time.