Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found some issues while running the
TraceState
implementation against my old test cases:::parse()
, was not applied in::with()
::parse()
discarded tracestates with length > 512; W3C spec specifies this as lower limit, not upper limit:::parse()
did not allow empty / whitespace-only members, W3C spec:This PR also changes the behavior for duplicate keys in
::parse()
; previously the last value was used, now the first (=newer) value is used; we might consider discarding the tracestate instead.key=value,key2=value2,key=value3
resulted previously inkey=value3,key2=value2
, now results inkey=value,key2=value2
.