Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include schema_url in FriendlySpanConverter #1292

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

sudol
Copy link
Contributor

@sudol sudol commented Apr 26, 2024

Regarding this issue: #1290

I believe this is the expected way to communicate the scheme used to a collector or downstream system attempting to analyze the telemetry, based on the documentation on the OpenTelemetry website.

Closes: #1290

@sudol sudol requested a review from a team April 26, 2024 16:19
Copy link

welcome bot commented Apr 26, 2024

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

Copy link

linux-foundation-easycla bot commented Apr 26, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.48%. Comparing base (8a6dd47) to head (cc72bbf).

❗ Current head cc72bbf differs from pull request most recent head 51cb8b0. Consider uploading reports for the commit 51cb8b0 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1292      +/-   ##
============================================
+ Coverage     74.31%   74.48%   +0.17%     
+ Complexity     2391     2384       -7     
============================================
  Files           349      348       -1     
  Lines          7124     7099      -25     
============================================
- Hits           5294     5288       -6     
+ Misses         1830     1811      -19     
Flag Coverage Δ
8.1 74.48% <100.00%> (+0.17%) ⬆️
8.2 74.48% <100.00%> (?)
8.3 74.48% <100.00%> (?)
8.4 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...c/SDK/Trace/SpanExporter/FriendlySpanConverter.php 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a6dd47...51cb8b0. Read the comment docs.

@brettmc brettmc merged commit 9fe6aa0 into open-telemetry:main Apr 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emit schema_url during exports
2 participants