-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHP 8.4] Fixes for implicit nullability deprecation #1297
Conversation
Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one. |
The committers listed above are authorized under a signed CLA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1297 +/- ##
=========================================
Coverage 73.97% 73.97%
Complexity 2365 2365
=========================================
Files 347 347
Lines 7071 7071
=========================================
Hits 5231 5231
Misses 1840 1840
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
@brettmc please create a PHP 8.4 compatible release to unblock Drupal upgrade |
Hi @andypost |
@brettmc Thank you, attempted to update packages allowed to get rid of patches! Meantime bikeshedding stuck on dependency on |
Fixes #1296