Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set OTLP 1.2.0 span parent/link remote flags #1298

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

Nevay
Copy link
Contributor

@Nevay Nevay commented Apr 29, 2024

@Nevay Nevay requested a review from a team April 29, 2024 18:41
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.00%. Comparing base (f2cba82) to head (b280eff).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1298      +/-   ##
============================================
+ Coverage     73.97%   74.00%   +0.02%     
- Complexity     2365     2367       +2     
============================================
  Files           347      347              
  Lines          7071     7077       +6     
============================================
+ Hits           5231     5237       +6     
  Misses         1840     1840              
Flag Coverage Δ
8.1 74.00% <100.00%> (+0.02%) ⬆️
8.2 74.00% <100.00%> (+0.02%) ⬆️
8.3 74.00% <100.00%> (+0.02%) ⬆️
8.4 72.86% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Contrib/Otlp/SpanConverter.php 99.08% <100.00%> (+0.05%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2cba82...b280eff. Read the comment docs.

@bobstrecansky bobstrecansky merged commit 8011431 into open-telemetry:main Apr 30, 2024
10 checks passed
@brettmc brettmc mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants