-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HookManagerInterface annotation #1395
Fix HookManagerInterface annotation #1395
Conversation
✅ Deploy Preview for opentelemetry-php canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1395 +/- ##
============================================
+ Coverage 73.88% 73.90% +0.02%
Complexity 2672 2672
============================================
Files 386 386
Lines 7650 7650
============================================
+ Hits 5652 5654 +2
+ Misses 1998 1996 -2
Flags with carried forward coverage won't be shown. Click here to find out more. see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
src/API/Instrumentation/AutoInstrumentation/HookManagerInterface.php
Outdated
Show resolved
Hide resolved
469b476
to
99c2166
Compare
99c2166
to
8a856db
Compare
…erInterface::hook signatures with OpenTelemetry\Instrumentation\hook.
8a856db
to
2061923
Compare
src/API/Instrumentation/AutoInstrumentation/HookManagerInterface.php
Outdated
Show resolved
Hide resolved
…ce.php Co-authored-by: Tobias Bachert <[email protected]>
Align OpenTelemetry\API\Instrumentation\AutoInstrumentation\HookManagerInterface::hook postHook Closure signature with OpenTelemetry\Instrumentation\hook.
Phan complains in open-telemetry/opentelemetry-php-contrib#269. Upon checking, I think the annotated signature of the post-hook is possibly incorrect?
This is an example of what I am seeing:.
In pre-hook:
In post-hook:
Edit: it was late and I pasted an example of pre-hook instead of post-hook. Both were throwing phan errors.