-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename phpdoc-to-github-pages to phpdoc-to-github-pages.yml #1425
Conversation
follow up to open-telemetry#1418, where I named the file without the required YML suffix
✅ Deploy Preview for opentelemetry-php canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1425 +/- ##
============================================
- Coverage 73.55% 73.46% -0.10%
Complexity 2683 2683
============================================
Files 387 387
Lines 7975 7973 -2
============================================
- Hits 5866 5857 -9
- Misses 2109 2116 +7
Flags with carried forward coverage won't be shown. Click here to find out more. see 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@svrnm - anything else you want us to do with this PR? Just merge? |
If that would be possible, yes. Testing github workflows is a nightmare. I also disabled it for pull requests since the goal should be a publication on commit to main |
That's worked: https://open-telemetry.github.io/opentelemetry-php/ |
thanks, let me add it to the website then :-) |
follow up to #1418, where I named the file without the required YML suffix