Allow values containing '=' in OTEL_RESOURCE_ATTRIBUTES #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wperron
force-pushed
the
fix-otel-resource-attributes-env-var
branch
from
2d61328 to
0b5d2b5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2120 +/- ##
=====================================
Coverage 77.9% 77.9%
=====================================
Files 123 123
Lines 22925 22925
=====================================
+ Hits 17870 17871 +1
+ Misses 5055 5054 -1 ☔ View full report in Codecov by Sentry. |
wperron
force-pushed
the
fix-otel-resource-attributes-env-var
branch
from
0b5d2b5 to
1e469c4
Compare
cijothomas
approved these changes
Nov 24, 2024
|
Hi, I'm on paternity leave right now, so it'll have to wait until I get
back in January 👋
…On Sun, Nov 24, 2024, 17:58 Cijo Thomas ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM. Could you resolve the conflicts so we can merge?
Apologies for the delay in getting to review this.
—
Reply to this email directly, view it on GitHub
<#2120 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI6SLDBEQ6CSNNFQDVCOTF32CJKZRAVCNFSM6AAAAABOJLXVWOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINJWHAZDOOBRGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
hdost
reviewed
Nov 26, 2024
| @@ -104,7 +104,7 @@ mod tests { | |||
| [ | |||
| ( | |||
| "OTEL_RESOURCE_ATTRIBUTES", | |||
| Some("key=value, k = v , a= x, a=z"), | |||
| Some("key=value, k = v , a= x, a=z,equal=value=,empty=,some=other=val"), | |||
There was a problem hiding this comment.
Replace this with an example using properties. The primary reason for allowing the additional = is in support of this feature.
wperron
force-pushed
the
fix-otel-resource-attributes-env-var
branch
from
1e469c4 to
d6e755c
Compare
Values passed in to `OTEL_RESOURCE_ATTRIBUTES` containing an equal sign `"="` are currently ignored by the Resource constructor, but should be accepted as it is part of the [W3C Baggage octet range](https://www.w3.org/TR/baggage/#header-content). Fixes open-telemetry#2110
wperron
force-pushed
the
fix-otel-resource-attributes-env-var
branch
from
d6e755c to
ad1aad6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Values passed in to
OTEL_RESOURCE_ATTRIBUTEScontaining an equal sign"="are currently ignored by the Resource constructor, but should be accepted as it is part of the W3C Baggage octetrange.
Fixes #2110
Changes
Updates the
EnvResourceDetectorto allow resource attributes values containing an equal sign ("=").Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes