Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide default implementation for MetricExporter trait methods #2479

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

cijothomas
Copy link
Member

No description provided.

@cijothomas cijothomas requested a review from a team as a code owner December 27, 2024 00:49
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.8%. Comparing base (d52fec7) to head (31a6bf6).

Files with missing lines Patch % Lines
opentelemetry-sdk/src/metrics/exporter.rs 66.6% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2479   +/-   ##
=====================================
  Coverage   77.8%   77.8%           
=====================================
  Files        123     124    +1     
  Lines      22864   22846   -18     
=====================================
- Hits       17800   17794    -6     
+ Misses      5064    5052   -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should require exporter author to think through the expected behavior rather than have a blank implementation. The benifit I see is we reduce some duplication in our code base.

Also adding a default implemtation is not breaking change but removing the default implementation is. Thus I prefer to not add default implemtation. Overall I don't think the benifit is worth the risk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants