Skip to content

Commit

Permalink
Fix triage script to ignore followup label removal when calculating c…
Browse files Browse the repository at this point in the history
…hanges. (#4226)
  • Loading branch information
austinlparker authored Sep 26, 2024
1 parent ee00d2e commit d50fcf5
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions .github/scripts/triage-helper/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,14 @@ def needs_followup(issue, verbose=False):
if last_meaningful_activity == deciding_label_added:
return False
if last_meaningful_activity > deciding_label_added:
if followup_label_removed:
# Only return True if there has been meaningful activity since the followup label was removed
return last_meaningful_activity > followup_label_removed
return True
if followup_label_removed and followup_label_removed < two_weeks_ago and last_meaningful_activity > followup_label_removed:
return True
if followup_label_removed and followup_label_removed > two_weeks_ago:
# If the followup label was removed more than two weeks ago and there's been no activity since,
# we don't need to add it back
return False

return False

Expand Down

0 comments on commit d50fcf5

Please sign in to comment.