Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional otel_scope_info configuration for prometheus exporter #3796

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

codeboten
Copy link
Contributor

Changes

Adding some more options that are exposed in the OTel Go SDK, but not specified in the prometheus exporter details.

@codeboten codeboten requested review from a team December 15, 2023 22:53
Adding some more options that are exposed in the OTel Go SDK, but not specified in the prometheus exporter details.

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten force-pushed the codeboten/without-scope-info branch from 3876117 to 4d5d7ed Compare December 15, 2023 22:53
Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Programmatic support for this is being added to opentelemetry-java in open-telemetry/opentelemetry-java#6015

@codeboten
Copy link
Contributor Author

@carlosalberto
Copy link
Contributor

cc @dashpole

@MrAlias
Copy link
Contributor

MrAlias commented Dec 19, 2023

cc @dashpole

@reyang reyang merged commit 24740fd into open-telemetry:main Dec 19, 2023
7 checks passed
@codeboten codeboten deleted the codeboten/without-scope-info branch December 19, 2023 23:21
codeboten pushed a commit to codeboten/opentelemetry-configuration that referenced this pull request Dec 19, 2023
jack-berg pushed a commit to open-telemetry/opentelemetry-configuration that referenced this pull request Dec 20, 2023
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants