Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: no search entries found page (#5372) #5462

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: no search entries found page (#5372) #5462

wants to merge 2 commits into from
+20 −6

Conversation

JennySimen
Copy link

Closes #5372

This PR creates a new and better search result page when the is no seach found.

Steps to view work

  1. Go to the registry page /ecosystem/registry
  2. Enter a word in the search bar which does not exist (e.g juice)
  3. View the new designed user interface

Screenshot 2024-10-23 025055

@JennySimen JennySimen requested a review from a team as a code owner October 23, 2024 01:56
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Oct 23, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

svrnm
svrnm requested changes Oct 23, 2024
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks very good, thank you! One comment around the image, otherwise 👍

assets/icons/search-not-found.png Show resolved Hide resolved
@svrnm svrnm added the outreachy Issues for Outreachy Participants label Oct 23, 2024
@svrnm svrnm changed the title feat: no search entries found page (#5372) [outreachy] feat: no search entries found page (#5372) Oct 23, 2024
@JennySimen
Copy link
Author

@svrnm Thank you very much for the feedback.

@svrnm svrnm changed the title [outreachy] feat: no search entries found page (#5372) ✅ [outreachy] feat: no search entries found page (#5372) Oct 23, 2024
@svrnm svrnm changed the title ✅ [outreachy] feat: no search entries found page (#5372) feat: no search entries found page (#5372) Nov 22, 2024
@svrnm svrnm mentioned this pull request Nov 25, 2024
Open
@svrnm svrnm added ux registry and removed outreachy Issues for Outreachy Participants labels Nov 26, 2024
@svrnm
Copy link
Member

svrnm commented Nov 26, 2024

@JennySimen we are currently discussion #5681 to enable the import of the 3rd party image, after this being resolved we should be able to merge your PR

@JennySimen
Copy link
Author

Thank you, looking forward to having the pr merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
registry ux
Projects
SIG Comms: PRs & Issues
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[outreachy] Registry: no entries found visualization
2 participants
@JennySimen @svrnm