Skip to content

Commit

Permalink
remove common http redefinition, move version to individual instruments
Browse files Browse the repository at this point in the history
  • Loading branch information
lmolkova committed Sep 29, 2023
1 parent b3439b1 commit 4126e01
Show file tree
Hide file tree
Showing 10 changed files with 98 additions and 317 deletions.
2 changes: 0 additions & 2 deletions docs/dotnet/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ path_base_for_github_subdir:

This document documents semantic conventions for metrics emitted by .NET runtime and individual components in .NET ecosystem.

**Disclaimer:** These are initial .NET metric instruments available in .NET 8 but more may be added in the future.

Following metrics are currently supported:

* [ASP.NET Core](dotnet-aspnetcore-metrics.md): Semantic Conventions for ASP.NET Core routing, exceptions, and rate-limiting *metrics*.
Expand Down
20 changes: 9 additions & 11 deletions docs/dotnet/dotnet-aspnetcore-metrics.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
# Semantic Conventions for ASP.NET Core 8.0 metrics
# Semantic Conventions for ASP.NET Core metrics

**Status**: [Experimental, Feature-freeze][DocumentStatus]

This document defines semantic conventions for ASP.NET Core metrics, not specific to HTTP

**Disclaimer:** These are initial .NET metric instruments available in .NET 8 but more may be added in the future.
This document defines semantic conventions for ASP.NET Core metrics.

<!-- toc -->

Expand Down Expand Up @@ -35,7 +33,7 @@ All routing metrics are reported by `Microsoft.AspNetCore.Routing` meter.
| -------- | --------------- | ----------- | -------------- |
| `aspnetcore.routing.match_attempts` | Counter | `{match_attempt}` | Number of requests that were attempted to be matched to an endpoint. [1] |

**[1]:** Meter name is `Microsoft.AspNetCore.Routing`.
**[1]:** Meter name: `Microsoft.AspNetCore.Routing`; Added in: ASP.NET Core 8.0
<!-- endsemconv -->

<!-- semconv metric.aspnetcore.routing.match_attempts(full) -->
Expand Down Expand Up @@ -67,7 +65,7 @@ Metrics reported by `Microsoft.AspNetCore.Diagnostics` meter.
| -------- | --------------- | ----------- | -------------- |
| `aspnetcore.diagnostics.exceptions` | Counter | `{exception}` | Number of exceptions caught by exception handling middleware. [1] |

**[1]:** Meter name is `Microsoft.AspNetCore.Diagnostics`
**[1]:** Meter name: `Microsoft.AspNetCore.Diagnostics`; Added in: ASP.NET Core 8.0
<!-- endsemconv -->

<!-- semconv metric.aspnetcore.diagnostics.exceptions(full) -->
Expand Down Expand Up @@ -100,7 +98,7 @@ All rate-limiting metrics are reported by `Microsoft.AspNetCore.RateLimiting` me
| -------- | --------------- | ----------- | -------------- |
| `aspnetcore.rate_limiting.active_request_leases` | UpDownCounter | `{request}` | Number of requests that are currently active on the server that hold a rate limiting lease. [1] |

**[1]:** Meter name is `Microsoft.AspNetCore.RateLimiting`
**[1]:** Meter name: `Microsoft.AspNetCore.RateLimiting`; Added in: ASP.NET Core 8.0
<!-- endsemconv -->

<!-- semconv metric.aspnetcore.rate_limiting.active_request_leases(full) -->
Expand All @@ -118,7 +116,7 @@ All rate-limiting metrics are reported by `Microsoft.AspNetCore.RateLimiting` me
| -------- | --------------- | ----------- | -------------- |
| `aspnetcore.rate_limiting.request_lease.duration` | Histogram | `s` | The duration of rate limiting lease held by requests on the server. [1] |

**[1]:** Meter name is `Microsoft.AspNetCore.RateLimiting`
**[1]:** Meter name: `Microsoft.AspNetCore.RateLimiting`; Added in: ASP.NET Core 8.0
<!-- endsemconv -->

<!-- semconv metric.aspnetcore.rate_limiting.request_lease.duration(full) -->
Expand All @@ -136,7 +134,7 @@ All rate-limiting metrics are reported by `Microsoft.AspNetCore.RateLimiting` me
| -------- | --------------- | ----------- | -------------- |
| `aspnetcore.rate_limiting.queued_requests` | UpDownCounter | `{request}` | Number of requests that are currently queued, waiting to acquire a rate limiting lease. [1] |

**[1]:** Meter name is `Microsoft.AspNetCore.RateLimiting`
**[1]:** Meter name: `Microsoft.AspNetCore.RateLimiting`; Added in: ASP.NET Core 8.0
<!-- endsemconv -->

<!-- semconv metric.aspnetcore.rate_limiting.queued_requests(full) -->
Expand All @@ -154,7 +152,7 @@ All rate-limiting metrics are reported by `Microsoft.AspNetCore.RateLimiting` me
| -------- | --------------- | ----------- | -------------- |
| `aspnetcore.rate_limiting.request.time_in_queue` | Histogram | `s` | The time request spent in a queue, waiting to acquire a rate limiting lease. [1] |

**[1]:** Meter name is `Microsoft.AspNetCore.RateLimiting`
**[1]:** Meter name: `Microsoft.AspNetCore.RateLimiting`; Added in: ASP.NET Core 8.0
<!-- endsemconv -->

<!-- semconv metric.aspnetcore.rate_limiting.request.time_in_queue(full) -->
Expand Down Expand Up @@ -184,7 +182,7 @@ All rate-limiting metrics are reported by `Microsoft.AspNetCore.RateLimiting` me

**[1]:** Requests could be rejected by global or endpoint rate limiting policies. Or the request could be cancelled while waiting for the lease.

Meter name is `Microsoft.AspNetCore.RateLimiting`
Meter name: `Microsoft.AspNetCore.RateLimiting`; Added in: ASP.NET Core 8.0
<!-- endsemconv -->

<!-- semconv metric.aspnetcore.rate_limiting.requests(full) -->
Expand Down
6 changes: 2 additions & 4 deletions docs/dotnet/dotnet-dns-metrics.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
# Semantic Conventions for DNS metrics emitted by .NET 8.0
# Semantic Conventions for DNS metrics emitted by .NET

**Status**: [Experimental, Feature-freeze][DocumentStatus]

This document defines semantic conventions for DNS metrics emitted by .NET.

**Disclaimer:** These are initial .NET metric instruments available in .NET 8 but more may be added in the future.

<!-- toc -->

- [DNS metrics](#dns-metrics)
Expand All @@ -22,7 +20,7 @@ This document defines semantic conventions for DNS metrics emitted by .NET.
| -------- | --------------- | ----------- | -------------- |
| `dns.lookup.duration` | Histogram | `s` | Measures the time taken to perform a DNS lookup. [1] |

**[1]:** Meter name is `System.Net.NameResolution`.
**[1]:** Meter name: `System.Net.NameResolution`; Added in: .NET 8.0
<!-- endsemconv -->

<!-- semconv metric.dotnet.dns.lookup.duration(full) -->
Expand Down
Loading

0 comments on commit 4126e01

Please sign in to comment.