-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace system.network.state with network.connection.state #1632
Conversation
ba65c2c
to
20e087c
Compare
@AlexanderWert @open-telemetry/specs-semconv-maintainers that should be good to go? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left a few suggestions to clean up old enum members
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
9e6babe
to
576493a
Compare
Signed-off-by: ChrsMark <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and thank you!
tagging @open-telemetry/semconv-security-approvers in case they want to take a look |
Co-authored-by: Alexandra Konrad <[email protected]>
@ChrsMark I think one test is failing, otherwise good to go! |
Signed-off-by: ChrsMark <[email protected]>
Fixes #308
Changes
ref: #308 (comment)
Merge requirement checklist
[chore]