Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace system.network.state with network.connection.state #1632

Merged
merged 9 commits into from
Dec 17, 2024

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Nov 29, 2024

Fixes #308

Changes

ref: #308 (comment)

Merge requirement checklist

@ChrsMark ChrsMark requested review from a team as code owners November 29, 2024 10:10
@ChrsMark ChrsMark force-pushed the fix_system_net_state branch from ba65c2c to 20e087c Compare November 29, 2024 10:11
@ChrsMark
Copy link
Member Author

ChrsMark commented Dec 2, 2024

@AlexanderWert @open-telemetry/specs-semconv-maintainers that should be good to go?

Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a few suggestions to clean up old enum members

schema-next.yaml Outdated Show resolved Hide resolved
model/network/registry.yaml Outdated Show resolved Hide resolved
model/network/registry.yaml Outdated Show resolved Hide resolved
model/network/registry.yaml Outdated Show resolved Hide resolved
model/network/registry.yaml Outdated Show resolved Hide resolved
@ChrsMark ChrsMark force-pushed the fix_system_net_state branch from 9e6babe to 576493a Compare December 13, 2024 09:42
Signed-off-by: ChrsMark <[email protected]>
@ChrsMark
Copy link
Member Author

@lmolkova @open-telemetry/semconv-system-approvers I have tuned the PR so as the state values to be aligned with rfc9293.

I'm not sure if we should explicitly deprecate the enum values that were changed or removed entirely.

Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thank you!

@lmolkova
Copy link
Contributor

tagging @open-telemetry/semconv-security-approvers in case they want to take a look

@trisch-me
Copy link
Contributor

@ChrsMark I think one test is failing, otherwise good to go!

Signed-off-by: ChrsMark <[email protected]>
@jsuereth jsuereth merged commit 3be2bcb into open-telemetry:main Dec 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Revisit system network metrics attributes
8 participants