Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Add recommendation for lowercase attribute names #788

Merged
merged 3 commits into from
Mar 1, 2024
Merged

[chore] Add recommendation for lowercase attribute names #788

merged 3 commits into from
Mar 1, 2024

Conversation

joaopgrassi
Copy link
Member

Fixes #586

Merge requirement checklist

@joaopgrassi joaopgrassi added the editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. label Feb 29, 2024
@joaopgrassi joaopgrassi requested review from a team February 29, 2024 13:22
@joaopgrassi joaopgrassi mentioned this pull request Feb 29, 2024
Closed
@joaopgrassi joaopgrassi merged commit 9e90894 into open-telemetry:main Mar 1, 2024
10 checks passed
@joaopgrassi joaopgrassi deleted the attribute-lowercase branch March 1, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@jack-berg jack-berg jack-berg approved these changes

@pyohannes pyohannes pyohannes approved these changes

@lmolkova lmolkova lmolkova approved these changes

@trask trask trask approved these changes

Assignees

@AlexanderWert AlexanderWert

Labels
editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind.
Projects
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add recommendation that attribute keys should be lowercase
7 participants
@joaopgrassi @trask @lmolkova @pyohannes @reyang @jack-berg @AlexanderWert