Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed guava lib #90

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Removed guava lib #90

wants to merge 2 commits into from

Conversation

itsergpot
Copy link
Collaborator

No description provided.

alex-tiurin
alex-tiurin requested changes Sep 28, 2024
View reviewed changes
ultron-android/src/main/kotlin/com/atiurin/ultron/custom/espresso/base/Checker.kt Outdated
import android.os.Looper


object Checker {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Давай добавим internal модифаейр, чтобы не был это объект виден в тестах

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rdy

ultron-android/src/main/kotlin/com/atiurin/ultron/custom/espresso/base/IterableUtils.kt Outdated

import org.hamcrest.Matcher

fun <T> filter(iterable: Iterable<T>, matcher: Matcher<T>): Iterable<T> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тоже всем методам надо internal добавить

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rdy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-tiurin alex-tiurin alex-tiurin requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itsergpot @alex-tiurin