Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for at-code coding system in addition to id-code coding system. #16

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Add support for at-code coding system in addition to id-code coding system. #16

wants to merge 24 commits into from

Conversation

sebastian-iancu
Copy link
Member

Add support for at-code coding system in addition to id-code coding system. Make the at-code coding system a requirement for openEHR RM compliant implementations.

(SPECAM-90)

TODO: add rendered html
Preview of new docs:

bostjanl-better and others added 8 commits June 8, 2024 19:59
@bostjanl-better @sebastian-iancu
ADL2 with added at-code codesystem
48e9b1e 
- added a new code specification for openEHR with at-codes
- added at-coded examples in ADL section
- reworked texts where it references id-codes to include at-codes

(SPECAM-90)
@bostjanl-better @sebastian-iancu
Add amendment records to AM and ADL (SPECAM-90)
83c49b6
@bostjanl-better @sebastian-iancu
Changes after review from TB (SPECAM-90)
25a95ac
@sebastian-iancu @freshehr
updating specs (by Ian McNicoll) to use asciidoc-tabs for ADL syntax …
a628884 
…examples (SPECAM-90)

Co-authored-by: Ian McNicoll <[email protected]>
@freshehr @joostholslag @sebastian-iancu
fixed typos and some formatting issues; updating Node identification …
4f0e3fd 
…intro and ADL2.4 changes (SPECAM-90)

Co-authored-by: Joost Holslag <[email protected]>
@sebastian-iancu
ignore .idea directory
5556fa5
@joostholslag @sebastian-iancu
updating examples to adl_version=2.4.0 (used replace all) (SPECAM-90)
8fe3d6f
@sebastian-iancu
fixing wording around codedsystem vs coding system; small formatt…
b874623 
…ing nd cross-reference (SPECAM-90)
@joostholslag
Copy link

joostholslag commented Jun 25, 2024 •
edited
Loading

@bostjanl-better Figure 5 in AOM2 should probably be updated. It lists (only) ID codes as node ids. https://specifications.openehr.org/releases/UML/latest/index.html#Diagrams___18_1_83e026d_1423307491544_806168_4397

@joostholslag
Copy link

“ The new coding system also carries original id-codes in its archetypes to preserve the original ADL2 codes.”
This sentence should be removed from aom2 2.3.3 similar to #14

@joostholslag
Copy link

“ Value_code_leader: String = "at" is not present in aom2.definitions for at coded archetype. Maybe it would help migrating and forward compatibility if we keep this as is from the aom2.definitions for id coded archetypes.

@joostholslag
Copy link

Should be put a not on Root_code_regex_pattern: String = "^at0000(.1)*$"
On numbering form 0 vs numbering from one in at vs id coded archetypes.

@joostholslag
Copy link

“The changes in release 2 of the ADL/AOM formalism are designed to make the formalism more computable with respect to terminology, and enable more rigorous validation and flattening operations.”
probabyly shouldn’t. Be part of aom2.changes from 2.0 -> 2.4. Also: no changes from 2.0->2.3??

mpolajnar
mpolajnar requested changes Jul 8, 2024
View reviewed changes
docs/ADL2/master07.11-adl_rules.adoc Show resolved Hide resolved
docs/ADL2/master04.5-cadl_primitive_types.adoc Show resolved Hide resolved
docs/ADL2/master04.5-cadl_primitive_types.adoc Show resolved Hide resolved
docs/ADL2/master04.5-cadl_primitive_types.adoc Outdated Show resolved Hide resolved
docs/ADL2/master04.5-cadl_primitive_types.adoc Show resolved Hide resolved
docs/ADL2/master07.10-adl_definition.adoc Show resolved Hide resolved
docs/ADL2/master07.10-adl_definition.adoc Show resolved Hide resolved
docs/ADL2/master07.11-adl_rulesNEW.adoc Show resolved Hide resolved
docs/ADL2/master07.11-adl_rulesNEW.adoc Outdated Show resolved Hide resolved
docs/ADL2/master07.13-adl_terminology.adoc Show resolved Hide resolved
@bostjanl-better
Remove "The new coding system also carries original id-codes in its a…
ba34661 
…rchetypes to preserve the original ADL2 codes.” from aom2
@bostjanl-better
Copy link

bostjanl-better commented Jul 15, 2024 •
edited
Loading

Should be put a not on Root_code_regex_pattern: String = "^at0000(.1)*$" On numbering form 0 vs numbering from one in at vs id coded archetypes.

I think it is clear as is, I would not add anything there - might make it more confusing...

@joostholslag
Copy link

Release of the following adl2.4 spec depends on: openEHR/specifications-BASE#14

@joostholslag
Copy link

@bostjanl-better are you able to add rendered html? Otherwise maybe @sebastian-iancu or @wolandscat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bostjanl-better bostjanl-better bostjanl-better left review comments

@MattijsK MattijsK MattijsK left review comments

@joostholslag joostholslag joostholslag left review comments

@mpolajnar mpolajnar mpolajnar requested changes

@freshehr freshehr freshehr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sebastian-iancu @joostholslag @bostjanl-better @freshehr @mpolajnar @MattijsK