Fixed :#1772 Error handling missing in GroupDetails #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therajanmaurya
requested changes
Feb 7, 2024
|
|
||
| private fun showUserInterface() { | ||
|
|
||
| sweetUIErrorHandler = SweetUIErrorHandler(requireActivity(), binding.root) |
There was a problem hiding this comment.
Remove this method and initialize the sweetUIErrorHandler globally in onCreateView
| } | ||
|
|
||
| private fun showErrorLayout() { | ||
| val errorMessage = getStringMessage(R.string.failed_to_load_group_details) |
There was a problem hiding this comment.
We already have showFetchingError method, please remove this method and move this logic in showFetchingError method.
| } | ||
|
|
||
| fun reloadOnError() { | ||
| sweetUIErrorHandler?.hideSweetErrorLayoutUI(binding.scrollGroupDetails, binding.layoutError) |
There was a problem hiding this comment.
Move this line in groupDetailsUiState GroupDetailsUiState.ShowProgressbar state and rename the method loadGroupDetailsAndAccounts()
|
@therajanmaurya pls review it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1772
Screenshots of UI changes.
1772.mp4
Please make sure these boxes are checked before submitting your pull request - thanks!
✅ Apply the
MifosStyle.xmlstyle template to your code in Android Studio.✅ Run the unit tests with
./gradlew checkto make sure you didn't break anything✅ If you have multiple commits please combine them into one commit by squashing them.