Fix#1182 #1190
Fix#1182 #1190
Conversation
|
@devansh-299 review this one, and also please give your thoughts about issue #1183. |
|
@devansh-299 review this when you're free. |
| dialog.dismiss() | ||
| finish() | ||
| editDetails(false); |
There was a problem hiding this comment.
please remove ; xD, also why removing finish() and making effort to re-set the textviews when we simply need to exit the activity on clicking accept
There was a problem hiding this comment.
Oooh sorry for that I got with the flow of java I made this mistake several times during this, I think I left one here😄, I'll resolve it in few minutes.
There was a problem hiding this comment.
@EGOR-IND can you explain the reasoning behind the re-setting of textviews before exiting and removing the finish() line, I might be missing something.
There was a problem hiding this comment.
Yeah, for sure, the reason why i removed finish() from the positive button of dialog box is that it was directly exiting the activity, which was the whole purpose of this PR making the exiting experience more better, so when user accept discarding changes then they will first go to the read only version of activity and then they can exit. You can see what my changes are doing from the video😊.
|
sergeant @devansh-299, made the changes you requested sir, review this sir, over n out XD. |
Issue Fix
Fixes #1182
Screenshots
WhatsApp.Video.2021-01-29.at.22.32.22.mp4
Description
enhanced the transition between view and edit state of SI Details activity.
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.