Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add F8-shortcut for language selection (jsc#SLE-12810, jsc#SLE-12479) #46

Merged
merged 2 commits into from
May 27, 2020

Conversation

wfeldt
Copy link
Member

@wfeldt wfeldt commented May 26, 2020

Task

Add F8 key option to switch to another language directly. And use to switch between Chinese/English.

Solution

This is controlled by these gfxboot.cfg config entries:

key.F8=extralang
extralang.locales=zh_CN,en_US
  • key.F8 assigns the extralang menu to F8
  • extralang.locales is a list of languages F8 iterates through (you can have more than two)

Note

I'm not using the proposed 中文安装 (Chinese Installation) as label but use the language name 简体中文(Simplified Chinese) which is used in other places.

This makes it useful for other languages as well.

Screenshots

foo1

foo2

@kobliha
Copy link
Member

kobliha commented May 26, 2020

I'm not using the proposed 中文安装 (Chinese Installation) as label but use the language name 简体中文(Simplified Chinese) which is used in other places.

Please USE what they want.

@kobliha
Copy link
Member

kobliha commented May 26, 2020

The point is that this is actually NOT a shortcut. This is an action button to switch all to Chinese Installation.

@wfeldt
Copy link
Member Author

wfeldt commented May 26, 2020

I don't see much of a difference.You already know that it's an installation, no point to mention it again.

@wfeldt
Copy link
Member Author

wfeldt commented May 26, 2020

This is for consistency. I'm using the language string we use everywhere else. It's the only way to make this extendable to other languages.

@wfeldt
Copy link
Member Author

wfeldt commented May 26, 2020

And Jira says 'Proposed lettering' so nothing set in stone.

@kobliha
Copy link
Member

kobliha commented May 26, 2020

@wfeldt I've asked PjM/PM to decide what they really want. This is not my decision.

@wfeldt
Copy link
Member Author

wfeldt commented May 26, 2020

Sure, they can comment here.

@jsrain
Copy link
Member

jsrain commented May 26, 2020

The current solution looks good for both Michal and Stefan. Let's wait with merging until tomorrow when a native speaker can review it.

@yifanjiang
Copy link

Hi, as a Chinese speaker (but do not know much about the gfxboot), IMHO, using the current wording 简体中文 is literally good and I agree it is a good choice to keep consistency. Meanwhile it may make F8 a bit confusing in the first place especially when F2 also uses the same wording after F8 is pressed.

If the F8's major purpose applies to the installer's language change, "中文安装" (Chinese installation) could be more easy to deliver meaningful sense of context to me.

Please let me know if we need more Chinese reviewers' opinion, I can contact them :-)

@yifanjiang
Copy link

To make myself clear, I think "Chinese Install" is a better to have option purely from language perspective. If we have a good reason to keep the consistency, I would say it is fine to keep it as it.

@wfeldt
Copy link
Member Author

wfeldt commented May 27, 2020

Meanwhile it may make F8 a bit confusing in the first place especially when F2 also uses the
same wording after F8 is pressed.

Note that the F8 label text changes to 'English' after you press F8 (to switch back to English). So there's no ambiguity.

@wfeldt
Copy link
Member Author

wfeldt commented May 27, 2020

That is basically the reason why I'd like to use the same language string as elsewhere.

'English Installation' is too long. And in case someone wants to use this for some other language we'd go translating stuff all over again.

@jsrain
Copy link
Member

jsrain commented May 27, 2020

Based on the collected feedback, please, merge and submit to SP2

@wfeldt wfeldt merged commit fb4d158 into master May 27, 2020
@wfeldt wfeldt deleted the sw_10 branch May 27, 2020 16:24
@chensixian
Copy link

chensixian commented Jun 10, 2020

"zh-cn" should be marked as: "中文(中国)"
There are many variants of Chinese: 中文(台灣),中文(香港),中文(中国),中文(马来西亚),中文(新加坡),中文(韓國),中文(越南),...
"简体中文(Simplified Chinese) " is a looser classification, 中文(中国)/中文(马来西亚)/中文(新加坡) is all Simplified Chinese.

                          +-+ 中文(台灣)= zh_TW
                          |
        繁體中文-----------+
           |              |
           |              +-+ 中文(香港)= zh_HK
中文-------+
           |              +-+ 中文(中国)= zh_CN
           |              |
        简体中文-----------+
           |              |
           |              +-+
           | 
           | 
          粵語-------------+

@wfeldt
Copy link
Member Author

wfeldt commented Jun 10, 2020

To be precise: we have currently "简体中文" and "繁體中文 (台灣)" in the language selection (via F2 or F8).

Do you mean to replace "简体中文" by "中文(中国)" and keep "繁體中文 (台灣)"?

@wfeldt
Copy link
Member Author

wfeldt commented Jun 10, 2020

Hm, after running all this through google translate, I quite like this approach.

@chensixian
Copy link

chensixian commented Jun 11, 2020

Common variants of Traditional Chinese(繁體中文) include zh_TW and zh_HK. The modern Chinese environment usually uses "正體中文" or "中文(台灣)" to accurately represent the Chinese variant of zh_TW.
In the regional language codes of "zh_CN, zh_TW, and zh_HK", "zh" is an abbreviation for Chinese(中文), and "CN" refers to China(中国), "TW" refers to TaiWan(台灣), "HK" refers to HongKong(香港).

@wfeldt
Copy link
Member Author

wfeldt commented Jun 12, 2020

I've done a tentative pull request: #47

@wfeldt
Copy link
Member Author

wfeldt commented Jun 12, 2020

For consistency, the same would be needed in the installer itself. See links in my pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants