-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add F8-shortcut for language selection (jsc#SLE-12810, jsc#SLE-12479) #46
Conversation
And use to switch between Chinese/English.
Please USE what they want. |
The point is that this is actually NOT a shortcut. This is an action button to switch all to |
I don't see much of a difference.You already know that it's an installation, no point to mention it again. |
This is for consistency. I'm using the language string we use everywhere else. It's the only way to make this extendable to other languages. |
And Jira says 'Proposed lettering' so nothing set in stone. |
@wfeldt I've asked PjM/PM to decide what they really want. This is not my decision. |
Sure, they can comment here. |
The current solution looks good for both Michal and Stefan. Let's wait with merging until tomorrow when a native speaker can review it. |
Hi, as a Chinese speaker (but do not know much about the gfxboot), IMHO, using the current wording 简体中文 is literally good and I agree it is a good choice to keep consistency. Meanwhile it may make F8 a bit confusing in the first place especially when F2 also uses the same wording after F8 is pressed. If the F8's major purpose applies to the installer's language change, "中文安装" (Chinese installation) could be more easy to deliver meaningful sense of context to me. Please let me know if we need more Chinese reviewers' opinion, I can contact them :-) |
To make myself clear, I think "Chinese Install" is a better to have option purely from language perspective. If we have a good reason to keep the consistency, I would say it is fine to keep it as it. |
Note that the F8 label text changes to 'English' after you press F8 (to switch back to English). So there's no ambiguity. |
That is basically the reason why I'd like to use the same language string as elsewhere. 'English Installation' is too long. And in case someone wants to use this for some other language we'd go translating stuff all over again. |
Based on the collected feedback, please, merge and submit to SP2 |
"zh-cn" should be marked as: "中文(中国)"
|
To be precise: we have currently "简体中文" and "繁體中文 (台灣)" in the language selection (via F2 or F8). Do you mean to replace "简体中文" by "中文(中国)" and keep "繁體中文 (台灣)"? |
Hm, after running all this through google translate, I quite like this approach. |
Common variants of Traditional Chinese(繁體中文) include zh_TW and zh_HK. The modern Chinese environment usually uses "正體中文" or "中文(台灣)" to accurately represent the Chinese variant of zh_TW. |
I've done a tentative pull request: #47 |
For consistency, the same would be needed in the installer itself. See links in my pull request. |
Task
Add
F8
key option to switch to another language directly. And use to switch between Chinese/English.Solution
This is controlled by these
gfxboot.cfg
config entries:key.F8
assigns theextralang
menu toF8
extralang.locales
is a list of languagesF8
iterates through (you can have more than two)Note
I'm not using the proposed 中文安装 (Chinese Installation) as label but use the language name 简体中文(Simplified Chinese) which is used in other places.
This makes it useful for other languages as well.
Screenshots