Fix archive name autodetection on OBS serveur #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go_modules service cannot be used on OBS server and generates an obscure error: 400 remote error: Error (http://obs2:5152/sourceupdate/project/golang-test) This is due to an invalid syntax in XML description field: '<' and '>' characters are not valid in value string.
Archive filename when using "tar_scm" and "recompress" services is _service:recompress:tar_scm:my_proj-1.0.0.tar.gz So update code to support both localrun with "basic" filename and obs server usecase. Signed-off-by: Sebastien Douheret <[email protected]>
sebd71
force-pushed
the
archive_detection
branch
from
6a2e601
to
7bee5c3
Compare
|
Thanks for the note and submission. I haven't used the decorated form of re-compressed archive names personally. I will look at this subject to gain a better understanding of the need and add support if needed. I want to be particularly conservative about filename handling from a security perspective given systems source services can run on. Further review to follow, thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Archive filename when using "tar_scm" and "recompress" services is
_service:recompress:tar_scm:my_proj-1.0.0.tar.gz
So update code to support both localrun with "basic" filename and obs
server usecase.