Enable "KeepAlive" probes for Salt SSH executions (bsc#1211649) #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meaksh
force-pushed
the
openSUSE/fix/3006.0-enable-keepalive-on-salt-ssh-connection
branch
from
2ed6008 to
cbb9186
Compare
vzhestkov
approved these changes
Nov 21, 2023
meaksh
changed the title
meaksh
deleted the
openSUSE/fix/3006.0-enable-keepalive-on-salt-ssh-connection
branch
meaksh
added a commit
that referenced
this pull request
Oct 29, 2024
* Enable KeepAlive probes for Salt SSH connections (bsc#1211649) * Add tests for Salt SSH keepalive options * Add changelog file * Make changes suggested by pre-commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a backport of saltstack/salt#65488 to
openSUSE/release/3006.0branch.What issues does this PR fix or reference?
Tracks: https://github.com/SUSE/spacewalk/issues/21578
What does this PR do?
This PR enables "KeepAlive" probes the SSH connections created by Salt SSH, in order to be more reliable when there are problems in the network or ssh stuck connections, preventing "salt-ssh" process from getting stuck (or even worse, "salt-api" threads getting stuck).
Previous Behavior
No
ServerAliveIntervalorServerAliveCountMaxoptions were passed to the "ssh" command.New Behavior
The KeepAlive proves (ServerAliveInterval) is now enabled by default for Salt SSH executions. This behavior can be disabled via configuration value / roster or CLI argument.
The following new configuration values were added to the Salt Master.
ssh_keepalive(default: True)ssh_keepalive_interval(default: 60)ssh_keepalive_count_max(default: 3)These new configuration values can be set via master configuration or passed to
salt-sshCLI.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes