Add test workflows based on salt-test #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some modules `import boto` to set log levels. The related tests don't import `boto`. This can cause a problem when `boto` is not available. Tests are skipped when HAS_BOTO in the test_boto_*.py is False. Not trying to `import boto` can leave HAS_BOTO=True in the test file even though HAS_BOTO is False on the application side. In this case, tests are not skipped and fail.
`salt.utils.path.which` should not be mocked before `network.__utils__`. The Salt loader calls `salt.utils.network.linux_interfaces`, which needs the real `salt.utils.path.which`.
Signed-off-by: Pedro Algarvio <[email protected]> (cherry picked from commit 3506e7f)
The same HAS_VCERT check is done in the runner module.
…reenaway original author (cherry picked from commit 2c1040b)
…tests. Signed-off-by: Pedro Algarvio <[email protected]> (cherry picked from commit 672f658)
These tests require a Git repository container, which is hard to correctly set up when executing the tests in the container in GH Actions. Using --network host can help, but there was still an error (the git repos were empty) when I tried to set this up.
agraul
force-pushed
the
update-testing-workflows-salt-test
branch
from
f569b37 to
cf5699a
Compare
agraul
changed the title
meaksh
force-pushed
the
update-testing-workflows-salt-test
branch
2 times, most recently
from
63d013b to
2274c0f
Compare
When GH Actions are executed, they skip the default entrypoint for the container, so we need to arrange the _version.txt file manually
meaksh
force-pushed
the
update-testing-workflows-salt-test
branch
from
2274c0f to
49fa25f
Compare
meaksh
force-pushed
the
update-testing-workflows-salt-test
branch
7 times, most recently
from
27db701 to
fb02996
Compare
Propagate GITHUB_ACTIONS variable to container environment
meaksh
force-pushed
the
update-testing-workflows-salt-test
branch
2 times, most recently
from
fb02996 to
c7be52c
Compare
vzhestkov
approved these changes
Feb 22, 2024
| from tests.support.runtests import RUNTIME_VARS | ||
|
|
||
| AVAILABLE_PYTHON_EXECUTABLE = salt.utils.path.which_bin( | ||
| ["python", "python2", "python2.6", "python2.7"] |
There was a problem hiding this comment.
Not sure if I understood why the whole test file was dropped, but I could assume due to missing python executable. Or am I wrong?
There was a problem hiding this comment.
These tests were actually just migrated and moved to this other file: https://github.com/openSUSE/salt/pull/616/files#diff-7f58f80c7428a46156300ebfac3a3ee8d98811d3e8e69fd26a51239c2dc6ee29
(Backported from: saltstack/salt#65679)
|
I've also pushed some of the commits from this PR upstream, via saltstack/salt#66130 |
meaksh
added a commit
that referenced
this pull request
Feb 26, 2024
* Add test workflows based on salt-test (#616) * Add unit test workflow based on salt-test * Add integration test workflow based on salt-test * Adjust GH actions to run all tests subsets and include functional * Add new GH action to trigger scenarios tests * GH Actions: Fix Salt version in _version.txt file When GH Actions are executed, they skip the default entrypoint for the container, so we need to arrange the _version.txt file manually Propagate GITHUB_ACTIONS variable to container environment
meaksh
added a commit
that referenced
this pull request
Oct 29, 2024
* Add test workflows based on salt-test (#616) * Add unit test workflow based on salt-test * Add integration test workflow based on salt-test * Adjust GH actions to run all tests subsets and include functional * Add new GH action to trigger scenarios tests * GH Actions: Fix Salt version in _version.txt file When GH Actions are executed, they skip the default entrypoint for the container, so we need to arrange the _version.txt file manually Propagate GITHUB_ACTIONS variable to container environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replace the salt-toaster based unit and integration test workflows with salt-test based ones. While adding these workflows, I came across a number of tests I had to fix. Where possible, I cherry-picked upstream fixes.
The hostname is set to
salt-test-container, which is used to conditionally disable tests that are problematic in GH Actions. If anyone has a better idea for either disabling these tests or know how to run them in GH Actions, I'm all for it.Needs updates to https://build.opensuse.org/package/show/systemsmanagement:saltstack:products:testing:containers:leap15.5/salt-testsuite-ci, see link diff