Allow kwargs for fileserver roots update (bsc#1218482) #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agraul
requested changes
Jan 11, 2024
ycedres
force-pushed
the
fix/allow-kargs-fileserver-roots-update
branch
from
06cc4a4 to
c218dda
Compare
ycedres
force-pushed
the
fix/allow-kargs-fileserver-roots-update
branch
from
c218dda to
fadbbf3
Compare
agraul
requested changes
Jan 16, 2024
vzhestkov
approved these changes
Jan 23, 2024
meaksh
added a commit
that referenced
this pull request
Oct 29, 2024
* Allow kwargs for fileserver roots update (bsc#1218482) * Prevent exceptions with fileserver.update when called via state * Fix wrong logic and enhance tests around fileserver.update * Remove test which is not longer valid --------- Co-authored-by: Pablo Suárez Hernández <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When an orchestration state is applied the user responsible for the runner is passed to the
updatefunction as the__pub_userkeyword argument. Therefore, theupdatefunction must be aware of this or the orchestration state application will fail.What issues does this PR fix or reference?
Fixes: https://github.com/SUSE/spacewalk/issues/23324
Upstream PR: saltstack/salt#65819
Previous Behavior
The application of this example orchestration state fails
with the following error:
New Behavior
Now the orchestrating state is applied correctly.
Additionally, it fixes wrong asserts on fileserver.update tests, as it was producing false positives when ret["return"] is a string (i.a. when errors are produced) instead of True value.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.