Make tests compatible with venv bundle #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-czernek
force-pushed
the
mczernek-fix-tests
branch
from
fb319b4 to
a041979
Compare
meaksh
reviewed
Jul 10, 2024
m-czernek
force-pushed
the
mczernek-fix-tests
branch
from
dcc1323 to
21ed917
Compare
|
I created PRs at: 3006.x branch: master/community-extensions branch: |
m-czernek
force-pushed
the
mczernek-fix-tests
branch
2 times, most recently
from
ee06a5a to
d8359f3
Compare
3 tasks
|
Note: After the PR is merged, this issue returns to backlog, since there are still more tests to take a look at. After the PR is merged, we should wait for the next Salt minor release and then merge https://github.com/openSUSE/salt-test-skiplist/tree/testing-failing-tests to enable the tests for our Jenkins pipelines. |
agraul
approved these changes
Jul 31, 2024
m-czernek
force-pushed
the
mczernek-fix-tests
branch
from
0e890ef to
52e4b3b
Compare
|
Squashing commits before merge such that:
|
This was referenced Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In this PR, we fix the
test_pipandtest_fileservertests to be compatible with venv minion bundle.This PR is a part of https://github.com/SUSE/spacewalk/issues/23536.
NOTE: This change includes the following commit: 96391b8
This commit will be reverted before merging. The commit modifies the skip list temporarily to actually test the modified tests.
In https://raw.githubusercontent.com/openSUSE/salt-test-skiplist/testing-failing-tests/skipped_tests.toml, I have commented out tests that are fixed by this PR for better readability.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.