-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip more tests related to old OpenSSL algorithms #669
Skip more tests related to old OpenSSL algorithms #669
Conversation
afd9ee4
to
4197319
Compare
I just found few more tests which seem failing due to the same reason:
These tests are marked as slow. |
4197319
to
afdc9cf
Compare
afdc9cf
to
d2aa248
Compare
@vzhestkov I included also those tests as you suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks for taking care of it.
as openSUSE/salt#669 get merged
* Remove x509_v2 tests which are not failing anymore Fixes are applied with: https://build.opensuse.org/request/show/1191122 openSUSE/salt#646 https://build.opensuse.org/projects/systemsmanagement:saltstack:bundle/packages/saltbundlepy-cryptography/files/definitions-ERR_GET.patch?expand=1&rev=31 * Remove latest failing x509_v2 tests as openSUSE/salt#669 get merged
What does this PR do?
There are some more tests failing in the test suite due to old OpenSSL versions that do not support some algorithms like
ed25519
.The same approach was followed in #646.
What issues does this PR fix or reference?
Tracks: https://github.com/SUSE/spacewalk/issues/23286
Previous Behavior
Failing tests on systems with old OpenSSL.
New Behavior
Unsupported algorithms skipped on systems with old OpenSSL.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.