Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip more tests related to old OpenSSL algorithms #669

Conversation

ycedres
Copy link
Contributor

@ycedres ycedres commented Jul 31, 2024

What does this PR do?

There are some more tests failing in the test suite due to old OpenSSL versions that do not support some algorithms like ed25519.

The same approach was followed in #646.

What issues does this PR fix or reference?

Tracks: https://github.com/SUSE/spacewalk/issues/23286

Previous Behavior

Failing tests on systems with old OpenSSL.

New Behavior

Unsupported algorithms skipped on systems with old OpenSSL.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@ycedres ycedres force-pushed the openSUSE/fix/3006.0/test_x509_v2-unsupported-algorithm branch from afd9ee4 to 4197319 Compare July 31, 2024 12:03
@ycedres ycedres requested a review from vzhestkov July 31, 2024 12:04
@ycedres ycedres marked this pull request as ready for review July 31, 2024 12:32
@vzhestkov
Copy link
Contributor

I just found few more tests which seem failing due to the same reason:

FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[None-der-ed25519] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[None-der-ed448] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[None-pem-ed25519] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[None-pem-ed448] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[hunter1-der-ed25519] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[hunter1-der-ed448] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[hunter1-pem-ed25519] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[hunter1-pem-ed448] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed_algo_change[existing_pk0] - assert False
ERROR tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed_existing[existing_pk2] - assert False
ERROR tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed_existing[existing_pk3] - assert False

These tests are marked as slow.
@ycedres could you please take a look on them also? I think they could be fixed similar way.

@ycedres ycedres force-pushed the openSUSE/fix/3006.0/test_x509_v2-unsupported-algorithm branch from 4197319 to afdc9cf Compare August 2, 2024 11:10
@ycedres ycedres force-pushed the openSUSE/fix/3006.0/test_x509_v2-unsupported-algorithm branch from afdc9cf to d2aa248 Compare August 2, 2024 11:16
@ycedres
Copy link
Contributor Author

ycedres commented Aug 2, 2024

I just found few more tests which seem failing due to the same reason:

FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[None-der-ed25519] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[None-der-ed448] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[None-pem-ed25519] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[None-pem-ed448] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[hunter1-der-ed25519] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[hunter1-der-ed448] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[hunter1-pem-ed25519] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed[hunter1-pem-ed448] - assert False
FAILED tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed_algo_change[existing_pk0] - assert False
ERROR tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed_existing[existing_pk2] - assert False
ERROR tests/pytests/functional/states/test_x509_v2.py::test_private_key_managed_existing[existing_pk3] - assert False

These tests are marked as slow. @ycedres could you please take a look on them also? I think they could be fixed similar way.

@vzhestkov I included also those tests as you suggested.

Copy link
Contributor

@vzhestkov vzhestkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for taking care of it.

@ycedres ycedres merged commit 63ff8ce into openSUSE/release/3006.0 Aug 7, 2024
8 checks passed
@ycedres ycedres deleted the openSUSE/fix/3006.0/test_x509_v2-unsupported-algorithm branch August 7, 2024 07:54
vzhestkov added a commit to openSUSE/salt-test-skiplist that referenced this pull request Aug 9, 2024
vzhestkov added a commit to openSUSE/salt-test-skiplist that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants