Handle logger flushing already closed file #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a partial cherry-pick of saltstack/salt@9683260
vzhestkov
approved these changes
Oct 17, 2024
| @@ -116,6 +119,7 @@ def flush(self): | |||
| super().handle(record) | |||
| finally: | |||
| self.__emitting = False | |||
| # This will raise a ValueError if the file handle has been closed. | |||
| super().flush() | |||
There was a problem hiding this comment.
I'm wondering why they haven't tried to catch this exception here, as in any case it should be ok just to hide it, no?
There was a problem hiding this comment.
I had the same thought, but it's a cherry-pick, so I used upstream's code...
m-czernek
merged commit e23dce1
into
openSUSE:openSUSE/release/3006.0
6 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial cherry-pick of
saltstack/salt@9683260
Note: Test failures are unrelated, fixed with openSUSE/salt-packaging#100
What does this PR do?
Fixes intermittent test failures.
What issues does this PR fix or reference?
Related to https://github.com/SUSE/spacewalk/issues/23286
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.