feat: Use ListenerItemExpectations for customer cancel #700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #698 for customer-requested cancellations
QA
I tested this against a booking system which is not yet stable, but was able to gain confidence that the feature works as expected.
These screenshots demonstrate some of this. They are a side-by-side comparison of the results for the
book-and-cancel
test. The LHS includes the changes and the RHS does not:Single mode:
Here, the booking system failed to produce the CustomerCancelled order feed change in the LHS test, but this lead to it failing at the order feed download step, as it could never be found. Whereas, in the RHS test, Test Suite passes the order feed download step but then later fails when asserting about orderItemStatuses
Multiple mode:
Here, the booking system succeeded in producing the CustomerCancelled order feed change, and so the LHS test passed (except an unrelated validation issue), whereas the RHS did not, because Broker latched onto an irrelevant order feed update (this booking system is one that produces such updates)