Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use ListenerItemExpectations for customer cancel #700

Conversation

lukehesluke
Copy link
Contributor

@lukehesluke lukehesluke commented Nov 1, 2024

Implements #698 for customer-requested cancellations

QA

I tested this against a booking system which is not yet stable, but was able to gain confidence that the feature works as expected.

These screenshots demonstrate some of this. They are a side-by-side comparison of the results for the book-and-cancel test. The LHS includes the changes and the RHS does not:

Single mode:
Screenshot 2024-11-01 at 11 31 04

Here, the booking system failed to produce the CustomerCancelled order feed change in the LHS test, but this lead to it failing at the order feed download step, as it could never be found. Whereas, in the RHS test, Test Suite passes the order feed download step but then later fails when asserting about orderItemStatuses

Multiple mode:
Screenshot 2024-11-01 at 11 32 04

Here, the booking system succeeded in producing the CustomerCancelled order feed change, and so the LHS test passed (except an unrelated validation issue), whereas the RHS did not, because Broker latched onto an irrelevant order feed update (this booking system is one that produces such updates)

@lukehesluke lukehesluke marked this pull request as ready for review November 1, 2024 11:39
@lukehesluke
Copy link
Contributor Author

Copy link
Collaborator

@nickevansuk nickevansuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nickevansuk nickevansuk merged commit d6ab1a8 into master Nov 1, 2024
32 checks passed
@nickevansuk nickevansuk deleted the feature/customer-requested-cancellation-listener-expectations branch November 1, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants