-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python 3.9 support #236
base: master
Are you sure you want to change the base?
python 3.9 support #236
Conversation
It seems that travis does not like the tag https://github.com/openai/retro/releases/tag/f347d7e Does anybody know what to do ? |
@nicoxxl, I think @christopherhesse created that tag because we had an issue getting a copy of the Integration UI. However, and Christopher can correct me if I'm wrong, my understanding was that release didn't change anything. He just made that release so he can formally upload some executables and binary files to run the Game Integration UI to GitHub so users can download it. When looking at Travis, it looks like your build isn't building on Linux (but works on MacOS). The Travis script seems to be trying to get information from Google and I know Christopher's release of uploading the Integration UI was to account for how that Google bucket was down. It's possible your issue is linked to the Google bucket being down. EDIT 1 minute after the fact: Wait what I said made no sense because Travis successfully built on macOS, which too, points to the Google stuff too. Are you sure you're able to compile this on Linux? |
Thanks for the PR! But yeah, I need to fix the GCS issue first before this will work correctly. |
Then I can remove that tag which is only there as a workaround. |
46916a3
to
e62bb4d
Compare
Inspired by commit bf21ddb
That would be nice, I tried to remove it from my fork bu it seems that travis still have it. Plus it block installing from source (at least with poetry):
|
Any update of this? Debian 11 is using Python 3.9 |
I believe I updated procgen https://github.com/openai/procgen but it took so long to migrate things that I didn't have time to look at this. There may be an easy fix here where the pipeline can be made to not depend on GCS anymore, but I don't have time currently to look into it. |
This project is very good, I hope someone fixes it. |
Any update? |
I think the pipeline would have to be ported to github actions. |
I tried to reproduce what was done in the commit bf21ddb.
That should resolve #219