Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of Docker, updated workflow #1063

Open
wants to merge 5 commits into
base: staging
Choose a base branch
from

Conversation

Gauvino
Copy link
Contributor

@Gauvino Gauvino commented Jul 12, 2024

Description

Most of the change are minim, like added codeql ci to test linting and security issue, update the action version, run test on ubuntu macsos and windows also.
Removed some warning in workflow also.
Cleanup dockerfile for a more lite weight image, test the image and build-it without problem, i removed some un-necessary package. Overall better syntax and removed some warning during building.

How Has This Been Tested?

Build the Dockerfile and run it.

Issue for the failed test: #1114

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@Gauvino Gauvino force-pushed the refactor-docker-ci branch from f69c26f to 5317fae Compare July 31, 2024 17:11
@Gauvino Gauvino changed the base branch from master to staging September 11, 2024 15:03
@Gauvino Gauvino mentioned this pull request Sep 11, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants