Skip to content
This repository has been archived by the owner on Oct 14, 2024. It is now read-only.

Commit

Permalink
ci: fix success check (#1280)
Browse files Browse the repository at this point in the history
The success is skipped instead of failed when depending jobs defined
in needs parameter are skipped/failed. Skipped success job threated the
same way as if it was successful therefore CI proceeds with merging PRs
in case auto-merge is enabled.
  • Loading branch information
chrisgacsal authored Feb 14, 2024
1 parent 6133fde commit 7efe2af
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,9 @@ jobs:
use_release_repository: false

success:
# https://github.com/actions/runner/issues/2566
# https://github.com/actions/toolkit/issues/581
if: ${{ !cancelled() && !contains(needs.*.result, 'cancelled') && !contains(needs.*.result, 'failure') }}
needs:
- build
- e2e
Expand Down

0 comments on commit 7efe2af

Please sign in to comment.