Skip to content
This repository has been archived by the owner on Oct 14, 2024. It is now read-only.

refactor: core/to pkg #1205

Merged
merged 1 commit into from
Feb 9, 2024
Merged

refactor: core/to pkg #1205

merged 1 commit into from
Feb 9, 2024

Conversation

chrisgacsal
Copy link
Contributor

Description

Refactor core/to package by renaming helper functions and adding documentation to the source code.

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@chrisgacsal chrisgacsal requested a review from a team as a code owner February 8, 2024 22:08
@chrisgacsal chrisgacsal self-assigned this Feb 8, 2024
@chrisgacsal chrisgacsal added the go Pull requests that update Go code label Feb 8, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
paralta
paralta previously approved these changes Feb 9, 2024
View reviewed changes
@chrisgacsal chrisgacsal added this pull request to the merge queue Feb 9, 2024
adamtagscherer
adamtagscherer previously approved these changes Feb 9, 2024
View reviewed changes
@chrisgacsal chrisgacsal removed this pull request from the merge queue due to a manual request Feb 9, 2024
@chrisgacsal chrisgacsal dismissed stale reviews from adamtagscherer and paralta via 967332b February 9, 2024 09:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1205-10fe4507f29ec150b4f95c197e8b03180b646465
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1205-10fe4507f29ec150b4f95c197e8b03180b646465
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1205-10fe4507f29ec150b4f95c197e8b03180b646465
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1205-10fe4507f29ec150b4f95c197e8b03180b646465
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1205-10fe4507f29ec150b4f95c197e8b03180b646465
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1205-10fe4507f29ec150b4f95c197e8b03180b646465

@adamtagscherer adamtagscherer self-requested a review February 9, 2024 09:48
@chrisgacsal chrisgacsal added this pull request to the merge queue Feb 9, 2024
Merged via the queue into main with commit 8d9f19c Feb 9, 2024
37 checks passed
@chrisgacsal chrisgacsal deleted the refactor-to-pkg branch February 9, 2024 10:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamtagscherer adamtagscherer adamtagscherer approved these changes

@paralta paralta paralta left review comments

Assignees

@chrisgacsal chrisgacsal

Labels
go Pull requests that update Go code
Projects
OpenClarity
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisgacsal @adamtagscherer @paralta