Skip to content
This repository has been archived by the owner on Oct 14, 2024. It is now read-only.

build: add go vet to checks #1347

Merged
merged 1 commit into from
Feb 22, 2024
Merged

build: add go vet to checks #1347

merged 1 commit into from
Feb 22, 2024

Conversation

chrisgacsal
Copy link
Contributor

Description]

Add go vet to check target in makefile in order to perform additional check prior running golangci-lint or test in order to catch certain issues early on like compilation errors.

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[x] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@chrisgacsal chrisgacsal requested a review from a team as a code owner February 22, 2024 12:18
@chrisgacsal chrisgacsal self-assigned this Feb 22, 2024
paralta
paralta previously approved these changes Feb 22, 2024
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1347-47d51b5952f2214d5185482de84cf0986692a488
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1347-47d51b5952f2214d5185482de84cf0986692a488
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1347-47d51b5952f2214d5185482de84cf0986692a488
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1347-47d51b5952f2214d5185482de84cf0986692a488
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1347-47d51b5952f2214d5185482de84cf0986692a488
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1347-47d51b5952f2214d5185482de84cf0986692a488

@chrisgacsal chrisgacsal added this pull request to the merge queue Feb 22, 2024
Merged via the queue into main with commit 3a39f01 Feb 22, 2024
36 checks passed
@chrisgacsal chrisgacsal deleted the add-go-vet branch February 22, 2024 15:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants