Skip to content
This repository has been archived by the owner on Oct 14, 2024. It is now read-only.

fix: add -C flag to go commands in Makefile #1350

Merged
merged 2 commits into from
Feb 23, 2024
Merged

fix: add -C flag to go commands in Makefile #1350

merged 2 commits into from
Feb 23, 2024

Conversation

adamtagscherer
Copy link
Contributor

@adamtagscherer adamtagscherer commented Feb 22, 2024 •
edited
Loading

Description

This PR fixes the dist-vmclarity-cli command in the Makefile, because it was broken.

It also switches the cd command for -C flag for go build go test and go generate commands.

Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@adamtagscherer adamtagscherer added the bug Something isn't working label Feb 22, 2024
@adamtagscherer adamtagscherer self-assigned this Feb 22, 2024
@adamtagscherer adamtagscherer requested a review from a team as a code owner February 22, 2024 16:13
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
ramizpolic
ramizpolic previously approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@ramizpolic ramizpolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

chrisgacsal
chrisgacsal reviewed Feb 22, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1350-3290b5236b520cfa79d44b155aec38a18d7928c4
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1350-3290b5236b520cfa79d44b155aec38a18d7928c4
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1350-3290b5236b520cfa79d44b155aec38a18d7928c4
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1350-3290b5236b520cfa79d44b155aec38a18d7928c4
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1350-3290b5236b520cfa79d44b155aec38a18d7928c4
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1350-3290b5236b520cfa79d44b155aec38a18d7928c4

chrisgacsal
chrisgacsal approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the updates! :shipit:

@adamtagscherer adamtagscherer added this pull request to the merge queue Feb 23, 2024
Merged via the queue into main with commit 99bc690 Feb 23, 2024
34 checks passed
@adamtagscherer adamtagscherer deleted the fix-makefile-go-commands branch February 23, 2024 10:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisgacsal chrisgacsal chrisgacsal approved these changes

@ramizpolic ramizpolic Awaiting requested review from ramizpolic

Assignees

@adamtagscherer adamtagscherer

Labels
bug Something isn't working
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamtagscherer @chrisgacsal @ramizpolic