Skip to content
This repository has been archived by the owner on Oct 14, 2024. It is now read-only.

refactor: Azure provider v2 #1351

Merged
merged 9 commits into from
Mar 1, 2024
Merged

refactor: Azure provider v2 #1351

merged 9 commits into from
Mar 1, 2024

Conversation

akijakya
Copy link
Contributor

@akijakya akijakya commented Feb 22, 2024

Description

Move code of Azure provider to provider/v2.

Tested using this guide with images created with the GO_BUILD_TAGS=providerv2 DOCKER_PUSH=true DOCKER_REGISTRY=<myregistry> make docker command.

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[X] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@akijakya akijakya added the provider:azure Issues relating to the Azure provider label Feb 22, 2024
@akijakya akijakya self-assigned this Feb 22, 2024
@akijakya akijakya force-pushed the refactor-azure-provider-v2 branch from 8509629 to 8353b15 Compare February 23, 2024 09:50

This comment has been minimized.

@akijakya akijakya marked this pull request as ready for review February 23, 2024 13:48
@akijakya akijakya requested a review from a team as a code owner February 23, 2024 13:48
provider/v2/azure/common/common.go Outdated Show resolved Hide resolved
provider/v2/azure/common/config.go Outdated Show resolved Hide resolved
provider/v2/azure/discoverer/discoverer.go Show resolved Hide resolved
provider/v2/azure/common/common.go Outdated Show resolved Hide resolved
@akijakya akijakya force-pushed the refactor-azure-provider-v2 branch from 8353b15 to a8ae5bd Compare February 26, 2024 13:22

This comment has been minimized.

@akijakya akijakya force-pushed the refactor-azure-provider-v2 branch from bc86f9c to 81a93db Compare February 26, 2024 16:05
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1351-9aa0aca4a7458154e639c77c962569823e5c6e47
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1351-9aa0aca4a7458154e639c77c962569823e5c6e47
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1351-9aa0aca4a7458154e639c77c962569823e5c6e47
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1351-9aa0aca4a7458154e639c77c962569823e5c6e47
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1351-9aa0aca4a7458154e639c77c962569823e5c6e47
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1351-9aa0aca4a7458154e639c77c962569823e5c6e47

Copy link
Member

@ramizpolic ramizpolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@akijakya akijakya added this pull request to the merge queue Mar 1, 2024
Merged via the queue into main with commit 3234503 Mar 1, 2024
34 checks passed
@akijakya akijakya deleted the refactor-azure-provider-v2 branch March 1, 2024 08:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
provider:azure Issues relating to the Azure provider
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants