This repository has been archived by the owner on Oct 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akijakya
force-pushed
the
refactor-azure-provider-v2
branch
from
February 23, 2024 09:50
8509629
to
8353b15
Compare
This comment has been minimized.
This comment has been minimized.
ramizpolic
reviewed
Feb 24, 2024
Signed-off-by: András Jáky <[email protected]>
Signed-off-by: András Jáky <[email protected]>
Signed-off-by: András Jáky <[email protected]>
Signed-off-by: András Jáky <[email protected]>
Signed-off-by: András Jáky <[email protected]>
Signed-off-by: András Jáky <[email protected]>
Signed-off-by: András Jáky <[email protected]>
Signed-off-by: András Jáky <[email protected]>
akijakya
force-pushed
the
refactor-azure-provider-v2
branch
from
February 26, 2024 13:22
8353b15
to
a8ae5bd
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: András Jáky <[email protected]>
akijakya
force-pushed
the
refactor-azure-provider-v2
branch
from
February 26, 2024 16:05
bc86f9c
to
81a93db
Compare
Hey! Your images are ready:
|
ramizpolic
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🚀
chrisgacsal
approved these changes
Feb 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move code of Azure provider to
provider/v2
.Tested using this guide with images created with the
GO_BUILD_TAGS=providerv2 DOCKER_PUSH=true DOCKER_REGISTRY=<myregistry> make docker
command.Type of Change
[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[X] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist