Skip to content
This repository has been archived by the owner on Oct 14, 2024. It is now read-only.

fix(e2e): default kics log-level to error to avoid excessive log messages #1955

Merged
merged 3 commits into from
Jul 26, 2024
Merged

fix(e2e): default kics log-level to error to avoid excessive log messages #1955

merged 3 commits into from
Jul 26, 2024

Conversation

csatib02
Copy link
Member

@csatib02 csatib02 commented Jul 23, 2024 •
edited
Loading

Description

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@csatib02 csatib02 changed the title fix: use log-level: error for kics e2e tests fix(e2e): use log-level: error for kics e2e tests Jul 23, 2024
@csatib02 csatib02 linked an issue Jul 23, 2024 that may be closed by this pull request
Excessive info logging by KICS plugin #1901
Closed
2 tasks
@csatib02 csatib02 self-assigned this Jul 23, 2024
@csatib02 csatib02 added bug Something isn't working scanners Issues related to adding new scanners labels Jul 23, 2024
@csatib02 csatib02 changed the title fix(e2e): use log-level: error for kics e2e tests fix(e2e): use log-level error for kics e2e tests Jul 23, 2024
@csatib02 csatib02 changed the title fix(e2e): use log-level error for kics e2e tests fix(e2e): set log-level to error for kics scanner when running e2e tests Jul 23, 2024
@csatib02 csatib02 marked this pull request as ready for review July 24, 2024 08:54
@csatib02 csatib02 requested a review from a team as a code owner July 24, 2024 08:54
zsoltkacsandi
zsoltkacsandi previously approved these changes Jul 24, 2024
View reviewed changes
@csatib02 csatib02 force-pushed the fix/excessive-log-messages-by-kics-scanner branch 4 times, most recently from 979ac95 to 6d89031 Compare July 24, 2024 11:59
@csatib02 csatib02 force-pushed the fix/excessive-log-messages-by-kics-scanner branch from 6d89031 to 36fb727 Compare July 24, 2024 12:04
@csatib02 csatib02 changed the title fix(e2e): set log-level to error for kics scanner when running e2e tests fix(e2e): default kics log-level to error to avoid excessive log messages Jul 25, 2024
@csatib02 csatib02 requested a review from paralta July 25, 2024 08:11
zsoltkacsandi
zsoltkacsandi previously approved these changes Jul 25, 2024
View reviewed changes
@csatib02 csatib02 force-pushed the fix/excessive-log-messages-by-kics-scanner branch 4 times, most recently from 0375a86 to b98300f Compare July 25, 2024 15:42
zsoltkacsandi
zsoltkacsandi previously approved these changes Jul 26, 2024
View reviewed changes
@csatib02
fix: create new context logger
304f648 
Signed-off-by: Bence Csati <[email protected]>

fix: create new ctx logger

Signed-off-by: Bence Csati <[email protected]>

fix: create new ctx logger

Signed-off-by: Bence Csati <[email protected]>

fix: create new ctx logger

Signed-off-by: Bence Csati <[email protected]>

fix: create new ctx logger

Signed-off-by: Bence Csati <[email protected]>

fix: create new ctx logger

Signed-off-by: Bence Csati <[email protected]>
@csatib02 csatib02 force-pushed the fix/excessive-log-messages-by-kics-scanner branch from b98300f to 304f648 Compare July 26, 2024 07:34
paralta
paralta approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@paralta paralta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@csatib02 csatib02 enabled auto-merge July 26, 2024 08:02
@csatib02 csatib02 added this pull request to the merge queue Jul 26, 2024
Merged via the queue into main with commit 3fd770c Jul 26, 2024
17 checks passed
@csatib02 csatib02 deleted the fix/excessive-log-messages-by-kics-scanner branch July 26, 2024 08:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paralta paralta paralta approved these changes

@zsoltkacsandi zsoltkacsandi zsoltkacsandi approved these changes

Assignees

@csatib02 csatib02

Labels
bug Something isn't working scanners Issues related to adding new scanners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Excessive info logging by KICS plugin
3 participants
@csatib02 @zsoltkacsandi @paralta