Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/504 add auth #518

Merged
merged 5 commits into from
May 30, 2024
Merged

Issue/504 add auth #518

merged 5 commits into from
May 30, 2024

Conversation

braddf
Copy link
Contributor

@braddf braddf commented May 30, 2024

Pull Request

Description

Add Auth0 integration and corresponding endpoints/auth loading state/logout page:

image

Fixes #504

N.B. also includes small fix for nowcasting-app as the SSR wasn't passing Cypress tests with date string formats being different between prerender on server and render on client-side, causing a React hydration error. Have forced the component to render client-side for now, but may need to keep an eye on this for date/time stuff.

How Has This Been Tested?

Locally and Vercel preview branch:
https://quartz-4su29j2w3-openclimatefix.vercel.app/

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@braddf braddf requested a review from peterdudfield May 30, 2024 10:38
@braddf braddf self-assigned this May 30, 2024
Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quartz-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 11:04am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nowcasting-app ⬜️ Ignored (Inspect) Visit Preview May 30, 2024 11:04am

@peterdudfield
Copy link
Contributor

Node CI error?

Copy link
Contributor

@peterdudfield peterdudfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great, and app seems to be working

Ive just left a few comments, do you mind looking at them?

@braddf
Copy link
Contributor Author

braddf commented May 30, 2024

Node CI error?

@peterdudfield Yes – this needs a bit of tinkering to get Cypress to run properly in the CI – I think I got most of the way there but need to revisit when I get a chance... is an expected error atm and it runs pre-commit successfully so should be okay in meantime

@braddf braddf merged commit 932e2e7 into development May 30, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants