Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quartz Energy v0.1.1 – Auth + Forecast Horizon Select #523

Merged
merged 18 commits into from
Jun 20, 2024
Merged

Conversation

braddf
Copy link
Contributor

@braddf braddf commented Jun 20, 2024

Pull Request – RELEASE

Features and Changes

Caveats and Dependencies

  • Auth vars need to be set for production environment in Vercel, to the same as the Preview – staging environment vars.

How Has This Been Tested?

Locally against local and dev APIs, and on dev deploy and staging deploy

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@braddf braddf added the release label Jun 20, 2024
@braddf braddf self-assigned this Jun 20, 2024
Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quartz-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 8:16am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nowcasting-app ⬜️ Ignored (Inspect) Jun 20, 2024 8:16am

@peterdudfield
Copy link
Contributor

anything changed on nowcasting-app?
node CI build failing?

@peterdudfield
Copy link
Contributor

Could you add in the PR descirption a link to the github issue for auth?

@braddf
Copy link
Contributor Author

braddf commented Jun 20, 2024

@peterdudfield Yep all good re the above:

  • minimal changes to nowcasting-app files to allow it to build/render consistently (server- vs. client-side rendering issue), but if it builds it should be identical as is just about how the imports are happening;
  • the Node CI will fail at the moment until I finish getting the end-to-end (Cypress) tests working in the CI, hopefully soon as I think I worked out the commands a few weeks ago.

@braddf
Copy link
Contributor Author

braddf commented Jun 20, 2024

N.B. preview branches are currently being funny with the Auth redirect, so I may have done that differently to nowcasting-app as they try to redirect back to the AUTH0_BASE_URL if set, i.e. staging.quartz.app in this case, which is not where it came from... I'll check it out in a bit, but the main staging URL on the proper subdomain works fine because it's explicitly set. 👍

@braddf braddf merged commit f22cb52 into main Jun 20, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

India: X forecast Auth0
2 participants