Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.5.1 – Remove old apps, Quartz Energy favicon & Quartz Solar GTM #532

Merged
merged 6 commits into from
Jul 24, 2024

Conversation

braddf
Copy link
Contributor

@braddf braddf commented Jul 23, 2024

Pull Request

Description

  • Remove unused apps
  • Correct default avatar to Quartz logo on Quartz Energy
  • Add Google Tag Manager to Quartz Solar

How Has This Been Tested?

Locally, on preview branches, on dev and on staging

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link

vercel bot commented Jul 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nowcasting-app ✅ Ready (Inspect) Visit Preview 1 resolved Jul 23, 2024 4:46pm
quartz-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 4:46pm

@peterdudfield
Copy link
Contributor

Should I worry the check doesn't work?

@peterdudfield
Copy link
Contributor

Also both staging websites work, but the links in the vercel bot dont? Perhaps im doing something wrong?

@braddf
Copy link
Contributor Author

braddf commented Jul 24, 2024

@peterdudfield thanks – re the check, no worries on the Node CI yet as it is not yet passing because of a config issue (on the list), and the links on the Vercel bot are another config thing as the redirects all go to the respective staging.quartz.* etc. so it gets confused and doesn't allow it 😅 but as long as the "real" links are working then that should be all good.

@braddf braddf merged commit 8f5edd0 into main Jul 24, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants