Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax check_evaluatable to allow subtypes of concept and predicate #2748

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

ngeiswei
Copy link
Member

@ngeiswei ngeiswei commented Aug 7, 2020

No description provided.

@ngeiswei ngeiswei merged commit 7193809 into opencog:master Aug 7, 2020
@ngeiswei ngeiswei deleted the relax-check_evaluatable branch August 25, 2020 07:44
@linas
Copy link
Member

linas commented Sep 9, 2021

Looking at #2814 and #2816 ... this change leads non-evaluatable evaluatables:

(use-modules (opencog))
(use-modules (opencog exec))
(cog-evaluate! (Concept "foo"))  ;crash!
(SequentialAnd  (Concept "foo"))  ; no error
(cog-evaluate!  (SequentialAnd  (Concept "foo")) ) ;crash!

Thus declaring ConceptNode to be evaluatable does not actually make it so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants