Improvements for preparation to separate test data into plain text files #114

ceefour · 2014-07-11T11:47:47Z

Refs #103.

amebel · 2014-07-14T07:26:06Z

It would be great if the improvements include the addition of the test data files. It would help me (at least) how it relates to the goal of having the test data separated from the code. But i will leave the decision to merge or not to @linas (treading on eggshells :-))

ceefour · 2014-07-14T07:29:43Z

The reason why I do this pull request is because test data always changing
all the time.

By the time the whole pull request is going to be merged, it's going to
diverge.

So after this pull request is merged, I can make another pull request that
only contains the conversions of test data from Java to text files.
On Jul 14, 2014 2:26 PM, "AmeBel" [email protected] wrote:

It would be great if the improvements include the addition of the test
data files. It would help me (at least) how it relates to the goal of
having the test data separated from the code. But i will leave the decision
to merge or not to @linas https://github.com/linas (treading on
eggshells :-))

—
Reply to this email directly or view it on GitHub
#114 (comment).

amebel · 2014-07-14T07:36:31Z

Ok thanks :-)

linas · 2014-07-14T17:04:32Z

I pulled this branch, and tried it. I promptly got an error:

BUILD FAILED
/home2/linas/src/novamente/src/relex-git/build.xml:80: Problem: failed to create task or type antlib:org.eclipse.aether.ant:pom
Cause: The name is undefined.
Action: Check the spelling.
Action: Check that any custom tasks/types have been declared.
Action: Check that any / declarations have taken place.
No types or tasks have been defined in this namespace yet

This appears to be an antlib declaration.
Action: Check that the implementing library exists in one of:
-/usr/share/ant/lib
-/home/linas/.ant/lib
-a directory added on the command line with the -lib argument

ceefour · 2014-07-14T17:44:55Z

@linas Thanks.

ceefour · 2014-07-14T17:48:21Z

@linas BTW, can you repeat ant again? i.e. the 'build failed' should happen only once (before the antlib is download) and after that it should build as normal.

ceefour@hendy:~/git/relex > ant
Buildfile: /home/ceefour/git/relex/build.xml
  [typedef] Could not load definitions from resource org/eclipse/aether/ant/antlib.xml. It could not be found.

build-subprojects:

init:
      [get] Getting: http://search.maven.org/remotecontent?filepath=org/eclipse/aether/aether-ant-tasks/1.0.0.v20140518/aether-ant-tasks-1.0.0.v20140518-uber.jar
      [get] To: /home/ceefour/git/relex/antlib/aether-ant-tasks-uber.jar
      [get] .......................................

BUILD FAILED
/home/ceefour/git/relex/build.xml:80: Problem: failed to create task or type antlib:org.eclipse.aether.ant:pom
Cause: The name is undefined.
Action: Check the spelling.
Action: Check that any custom tasks/types have been declared.
Action: Check that any <presetdef>/<macrodef> declarations have taken place.
No types or tasks have been defined in this namespace yet

This appears to be an antlib declaration. 
Action: Check that the implementing library exists in one of:
        -/usr/share/ant/lib
        -/home/ceefour/.ant/lib
        -a directory added on the command line with the -lib argument


Total time: 30 seconds

ceefour@hendy:~/git/relex > ant
Buildfile: /home/ceefour/git/relex/build.xml

build-subprojects:

init:
      [get] Destination already exists (skipping): /home/ceefour/git/relex/antlib/aether-ant-tasks-uber.jar
[artifact:resolve] Using default pom for dependency resolution (org.opencog:relex:1.5.2-SNAPSHOT (org.eclipse.aether.internal.ant.types.Pom@7eac9008))
[artifact:resolve] Resolving artifacts

build-version:
     [echo] Building RelEx version 1.5.1
     [copy] Copying 1 file to /home/ceefour/git/relex/src/java/relex

look-for-owl:
     [echo] Will not build (optional) OWL output format; org.semanticweb.owl classes not found.

look-for-opennlp-1.5:
     [echo] Could not find OpenNLP-1.5 classes; looking for OpenNLP-1.4.

look-for-opennlp-1.4:
     [echo] Looking for (optional) OpenNLP-1.4...

look-for-opennlp:

build-project:
     [echo] relex: /home/ceefour/git/relex/build.xml
    [javac] Compiling 2 source files to /home/ceefour/git/relex/bin

build:

BUILD SUCCESSFUL
Total time: 1 second

linas · 2014-07-14T18:09:02Z

Hmm. Indeed, its now running. It downloaded 25 megabytes of .. what seems like useless junk: clerezza httpcomponents jena wymiwyg slf4j hamcrest fasterxml guava .. stuff that the current relex has no dependency on. And then it failed again:

BUILD FAILED
/home2/linas/src/novamente/src/relex-git/build.xml:81: Could not resolve artifacts: The following artifacts could not be resolved: org.apache.odftoolkit:odfdom-java:jar:0.8.9-incubating, org.apache.odftoolkit:simple-odf:jar:0.8-incubating, org.linkgrammar:linkgrammar:jar:5.0.8: Could not find artifact org.apache.odftoolkit:odfdom-java:jar:0.8.9-incubating in central (http://repo1.maven.org/maven2/)

linas · 2014-07-14T18:10:50Z

Can this be trimmed down, so that it only downloads what is actually needed? It looks to be walking down the path of DLL hell, from what I can tell.

ceefour · 2014-07-14T18:38:35Z

@linas I've trimmed it. The updated commit should build & test successfully with Ant. My output:

...
build-version:
     [echo] Building RelEx version 1.5.1
     [copy] Copying 1 file to /home/ceefour/git/relex/src/java/relex

look-for-owl:
     [echo] Will not build (optional) OWL output format; org.semanticweb.owl classes not found.

look-for-opennlp-1.5:
     [echo] Could not find OpenNLP-1.5 classes; looking for OpenNLP-1.4.

look-for-opennlp-1.4:
     [echo] Looking for (optional) OpenNLP-1.4...

look-for-opennlp:

build-project:
     [echo] relex: /home/ceefour/git/relex/build.xml
    [javac] Compiling 1 source file to /home/ceefour/git/relex/bin

build-tests:
     [echo] relex: /home/ceefour/git/relex/build.xml
    [javac] Compiling 2 source files to /home/ceefour/git/relex/bin
    [javac] warning: [options] bootstrap class path not set in conjunction with -source 1.5
    [javac] warning: [options] source value 1.5 is obsolete and will be removed in a future release
    [javac] warning: [options] target value 1.5 is obsolete and will be removed in a future release
    [javac] warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
    [javac] 4 warnings
...

linas · 2014-07-14T19:02:35Z

Much better! One warning:

[javac] ----------
[javac] 1. WARNING in /home2/linas/src/novamente/src/relex-git/src/java_test/relex/test/TestStanford.java (at line 146)
[javac]     TestStanford ts = new TestStanford();
[javac]                  ^^
[javac] The local variable ts is never read

linas · 2014-07-14T19:03:25Z

java5.settings.xml

+    <activeProfiles>
+    	<activeProfile>java5</activeProfile>
+    </activeProfiles>
+</settings>


missing newline

Improvements for preparation to separate test data into plain text files

ceefour · 2014-07-14T19:08:18Z

@linas newline fixed. that "warning" was real, fixed.

your merged master already contains the fixed ones.

Thanks Dr. Vepstas :) 👍

Improvements for preparation to separate test data into plain text fi…

c90ab52

…les. Refs opencog#103.

Merge remote-tracking branch 'origin/master' into testtsv2

0b5cbe8

linas reviewed Jul 14, 2014
View reviewed changes

java5.settings.xml

<activeProfiles>

<activeProfile>java5</activeProfile>

</activeProfiles>

</settings>

Copy link

Member

linas Jul 14, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing newline

Trim dependencies. Refs opencog#103.

d4beb60

linas added a commit that referenced this pull request Jul 14, 2014

Merge pull request #114 from ceefour/testtsv2

a5939b9

Improvements for preparation to separate test data into plain text files

linas merged commit a5939b9 into opencog:master Jul 14, 2014

ceefour mentioned this pull request Jul 14, 2014

Move test fixtures into TSV plain text files. #119

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improvements for preparation to separate test data into plain text files #114

Improvements for preparation to separate test data into plain text files #114

ceefour commented Jul 11, 2014

amebel commented Jul 14, 2014

ceefour commented Jul 14, 2014

amebel commented Jul 14, 2014

linas commented Jul 14, 2014

ceefour commented Jul 14, 2014

ceefour commented Jul 14, 2014

linas commented Jul 14, 2014

linas commented Jul 14, 2014

ceefour commented Jul 14, 2014

linas commented Jul 14, 2014

linas Jul 14, 2014

ceefour commented Jul 14, 2014

Improvements for preparation to separate test data into plain text files #114

Improvements for preparation to separate test data into plain text files #114

Conversation

ceefour commented Jul 11, 2014

amebel commented Jul 14, 2014

ceefour commented Jul 14, 2014

amebel commented Jul 14, 2014

linas commented Jul 14, 2014

ceefour commented Jul 14, 2014

ceefour commented Jul 14, 2014

linas commented Jul 14, 2014

linas commented Jul 14, 2014

ceefour commented Jul 14, 2014

linas commented Jul 14, 2014

linas Jul 14, 2014

Choose a reason for hiding this comment

ceefour commented Jul 14, 2014