Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out Unify into it's own git repo #127

Merged
merged 5 commits into from
Dec 2, 2022
Merged

Split out Unify into it's own git repo #127

merged 5 commits into from
Dec 2, 2022

Conversation

linas
Copy link
Member

@linas linas commented Dec 2, 2022

Unify is now in https://github.com/opencog/unify
Make it into a proper dependency for the URE.

Splitting out Unify enables it to be developed on it's own.

General plan for Unify: Create a new Atomese UnifyLink

As far as I can tell, (Unify A B) is equivalent to (Get (Identical A B)) In greater detail,

(Unify
    (Inheritance  (Concept "A") (Variable "$Y"))
    (Inheritance (Variable "$X") (Concept "B")))

is equivalent to the more verbose

(Get
    (VariableList
       (Variable "$X") (Variable "$Y"))
    (Identical
         (Inheritance  (Concept "A") (Variable "$Y"))
         (Inheritance (Variable "$X") (Concept "B")))))

Both will return

(Set
    (List (Concept "A") (Concept "B")))

Differences are unclear, I'm hoping @ngeiswei will help clarify over time (back-burner project)

@linas linas merged commit 75228e1 into master Dec 2, 2022
@linas linas deleted the de-unify branch December 2, 2022 22:13
@ngeiswei
Copy link
Member

ngeiswei commented Dec 3, 2022

Oh, I didn't know (Get (Indentical A B)) acted as a unifier. If so, all that unify code might just be redundant. There is a plethora of tests under tests/unify, maybe some important differences can be found.

@linas
Copy link
Member Author

linas commented Dec 4, 2022

I now understand that the unifier, and IdenticalLink are similar, but not the same. The Unifier handles more difficult cases. This is reviewed in opencog/unify#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants